Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 806823002: Ignore text elements for menu item related roles. (Closed)

Created:
6 years ago by k.czech
Modified:
6 years ago
Reviewers:
dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Ignore text elements for menu item related roles. Text elements should go along with menu item related roles. Let's consider this example: <div role="menuitemcheckbox" tabindex="0">menu item checkbox</div> Currently MenuItemCheckBoxRole is represented by accessible object and its title is the second accessible object. Expected behavior is that we should have just one accessible object. BUG=442278 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187323

Patch Set 1 #

Patch Set 2 : Make sure parent object is always a valid object #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
A LayoutTests/accessibility/ignore-text-elements-for-menu-item-related-roles.html View 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/accessibility/ignore-text-elements-for-menu-item-related-roles-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXRenderObject.cpp View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
k.czech
6 years ago (2014-12-15 13:13:34 UTC) #1
k.czech
6 years ago (2014-12-16 19:19:23 UTC) #3
dmazzoni
lgtm
6 years ago (2014-12-17 01:03:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806823002/20001
6 years ago (2014-12-17 01:03:38 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=187323
6 years ago (2014-12-17 02:20:47 UTC) #7
alancutter (OOO until 2018)
6 years ago (2014-12-17 10:09:43 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698