Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 796223003: Revert of Ignore text elements for menu item related roles. (Closed)

Created:
6 years ago by alancutter (OOO until 2018)
Modified:
6 years ago
Reviewers:
dmazzoni, k.czech
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Ignore text elements for menu item related roles. (patchset #2 id:20001 of https://codereview.chromium.org/806823002/) Reason for revert: Broke the Win 7 Tests builder: http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests Example build failure: http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/7521 Two content_browser tests tests failing: https://chromium.googlesource.com/chromium/src/+/master/content/test/data/accessibility/aria-menuitemcheckbox.html https://chromium.googlesource.com/chromium/src/+/master/content/test/data/accessibility/aria-menuitemradio.html Original issue's description: > Ignore text elements for menu item related roles. > > Text elements should go along with menu item related roles. > Let's consider this example: <div role="menuitemcheckbox" tabindex="0">menu item checkbox</div> > Currently MenuItemCheckBoxRole is represented by accessible object and its title is the second > accessible object. Expected behavior is that we should have just one accessible object. > > BUG=442278 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187323 TBR=dmazzoni@chromium.org,k.czech@samsung.com NOTREECHECKS=true NOTRY=true BUG=442278 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187355

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -45 lines) Patch
D LayoutTests/accessibility/ignore-text-elements-for-menu-item-related-roles.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/accessibility/ignore-text-elements-for-menu-item-related-roles-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/modules/accessibility/AXRenderObject.cpp View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
alancutter (OOO until 2018)
Created Revert of Ignore text elements for menu item related roles.
6 years ago (2014-12-17 10:09:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796223003/1
6 years ago (2014-12-17 10:10:04 UTC) #2
commit-bot: I haz the power
6 years ago (2014-12-17 10:10:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187355

Powered by Google App Engine
This is Rietveld 408576698