Converts usage of GetBrowserViewForNativeWindow to

Converts usage of GetBrowserViewForNativeWindow to
GetBrowserViewForBrowser. There is one place still using
GetBrowserViewForNativeWindow and that's the tab dragging code which
needs to use it.

BUG=none
TEST=none
R=asargent, pinkerton, erg, pkasting, ben

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103514

[sky, 2011-09-29 03:44:35]

I touched a lot of files as I converted ShowPageInfoBubble from taking a
NativeWindow to take a Browser.

asargent: extensions
pinkerton: cocoa
gtk: erg
pkasting: infobar stuff
ben: the rest

Thanks!

  -Scott

[asargent_no_longer_on_chrome, 2011-09-29 16:46:04]

extensions parts LGTM

[Elliot Glaysher, 2011-09-29 17:34:28]

gtk lgtm

[Peter Kasting, 2011-09-29 17:39:19]

Infobars LGTM

http://codereview.chromium.org/8068020/diff/2001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_infobar_delegate.h (right):

http://codereview.chromium.org/8068020/diff/2001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_infobar_delegate.h:47: Browser* browser() {
return browser_; }
Nit: Not necessary.  The only caller is an ExtensionInfoBarDelegate member
function that can use |browser_| directly.

http://codereview.chromium.org/8068020/diff/2001/chrome/browser/ui/views/info...
File chrome/browser/ui/views/infobars/extension_infobar.cc (right):

http://codereview.chromium.org/8068020/diff/2001/chrome/browser/ui/views/info...
chrome/browser/ui/views/infobars/extension_infobar.cc:36:
ExtensionInfoBar::ExtensionInfoBar(Browser* browser,
Nit: This should probably go at the end of the list, and |browser_| should go in
the member list after |delegate_|.

[sky, 2011-09-29 21:51:20]

I've incorporated feedback and made page_info_window platform specific as
suggested by Ben.

[pink (ping after 24hrs), 2011-09-29 21:56:38]

Cocoa LGTM, one larger design question that's probably beyond the scope of this
CL.

http://codereview.chromium.org/8068020/diff/6002/chrome/browser/ui/cocoa/page...
File chrome/browser/ui/cocoa/page_info_window.h (right):

http://codereview.chromium.org/8068020/diff/6002/chrome/browser/ui/cocoa/page...
chrome/browser/ui/cocoa/page_info_window.h:18: Profile* profile,
does this have to take a full Profile? Can it just take the object that's needed
out of it?

[sky, 2011-09-29 22:09:18]

On Thu, Sep 29, 2011 at 2:56 PM,  <pinkerton@chromium.org> wrote:
> Cocoa LGTM, one larger design question that's probably beyond the scope of
> this
> CL.
>
>
>
http://codereview.chromium.org/8068020/diff/6002/chrome/browser/ui/cocoa/page...
> File chrome/browser/ui/cocoa/page_info_window.h (right):
>
>
http://codereview.chromium.org/8068020/diff/6002/chrome/browser/ui/cocoa/page...
> chrome/browser/ui/cocoa/page_info_window.h:18: Profile* profile,
> does this have to take a full Profile? Can it just take the object
> that's needed out of it?
>
> http://codereview.chromium.org/8068020/

I think it could be done on cocoa and views, but would require a
number of other changes. I'll leave that for later.

  -Scott

[Ben Goodger (Google), 2011-09-30 16:52:59]

LGTM