Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1308)

Unified Diff: chrome/browser/ui/views/page_info_bubble_view.cc

Issue 8068020: Converts usage of GetBrowserViewForNativeWindow to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporate review feedback, and make ShowPageInfo platform specific Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/page_info_bubble_view.cc
diff --git a/chrome/browser/ui/views/page_info_bubble_view.cc b/chrome/browser/ui/views/page_info_bubble_view.cc
index d8fbad7ca61fdfdb37fb7d4721f668ce1b8e64a9..14124c154013102a2eba780a5c4fdd4af1506a9c 100644
--- a/chrome/browser/ui/views/page_info_bubble_view.cc
+++ b/chrome/browser/ui/views/page_info_bubble_view.cc
@@ -474,14 +474,12 @@ gfx::Size Section::LayoutItems(bool compute_bounds_only, int width) {
namespace browser {
-void ShowPageInfoBubble(gfx::NativeWindow parent,
+void ShowPageInfoBubble(BrowserView* browser_view,
Profile* profile,
const GURL& url,
const NavigationEntry::SSLStatus& ssl,
bool show_history) {
// Find where to point the bubble at.
- BrowserView* browser_view =
- BrowserView::GetBrowserViewForNativeWindow(parent);
gfx::Point point;
if (base::i18n::IsRTL()) {
int width = browser_view->toolbar()->location_bar()->width();
@@ -496,7 +494,8 @@ void ShowPageInfoBubble(gfx::NativeWindow parent,
// Show the bubble. If the bubble already exist - it will be closed first.
PageInfoBubbleView* page_info_bubble =
- new PageInfoBubbleView(parent, profile, url, ssl, show_history);
+ new PageInfoBubbleView(browser_view->GetNativeHandle(),
+ profile, url, ssl, show_history);
Bubble* bubble =
Bubble::Show(browser_view->GetWidget(), bounds,
views::BubbleBorder::TOP_LEFT,

Powered by Google App Engine
This is Rietveld 408576698