Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 806773006: Revert of IDL: Properly support [Exposed] on static methods (Closed)

Created:
6 years ago by samuong
Modified:
6 years ago
Reviewers:
haraken, Jens Widell
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of IDL: Properly support [Exposed] on static methods (patchset #2 id:20001 of https://codereview.chromium.org/793243004/) Reason for revert: seems to be causing compile failures: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/101401/steps/compile/logs/stdio Original issue's description: > IDL: Properly support [Exposed] on static methods > > They were conditionally installed as indicated by the [Exposed] attribute, > but they were installed on the prototype object rather than on the > interface object. > > A static method with [Exposed] fulfills the requirements for being treated > both as a conditionally enabled method (because of [Exposed]) and a method > with custom registration (because of being static), and due to the order > in which those requirements were checked, it ended up being treated as a > conditionally enabled method, only. > > Fix by giving custom registration priority and by adding the same > condition filters around that registration code, so that such methods can > still also be all sorts of conditionally enabled. > > BUG=434741 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187161 TBR=haraken@chromium.org,jl@opera.com NOTREECHECKS=true NOTRY=true BUG=434741 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187182

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -48 lines) Patch
M Source/bindings/scripts/v8_interface.py View 1 chunk +1 line, -4 lines 0 comments Download
M Source/bindings/templates/interface_base.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 chunk +6 lines, -12 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 2 chunks +6 lines, -12 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 2 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
samuong
Created Revert of IDL: Properly support [Exposed] on static methods
6 years ago (2014-12-15 21:40:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806773006/1
6 years ago (2014-12-15 21:41:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=187182
6 years ago (2014-12-15 21:42:29 UTC) #3
haraken
LGTM
6 years ago (2014-12-15 23:44:23 UTC) #4
Jens Widell
Failure caused by https://code.google.com/p/chromium/issues/detail?id=313077 I guess. Unlikely this patch made a difference. I can't revert ...
6 years ago (2014-12-16 06:11:07 UTC) #5
haraken
On 2014/12/16 06:11:07, Jens Widell wrote: > Failure caused by https://code.google.com/p/chromium/issues/detail?id=313077 I > guess. Unlikely ...
6 years ago (2014-12-16 06:20:01 UTC) #6
haraken
On 2014/12/16 06:20:01, haraken wrote: > On 2014/12/16 06:11:07, Jens Widell wrote: > > Failure ...
6 years ago (2014-12-16 06:21:25 UTC) #7
Jens Widell
6 years ago (2014-12-16 06:22:16 UTC) #8
Message was sent while issue was closed.
On 2014/12/16 06:21:25, haraken wrote:
> On 2014/12/16 06:20:01, haraken wrote:
> > On 2014/12/16 06:11:07, Jens Widell wrote:
> > > Failure caused by
https://code.google.com/p/chromium/issues/detail?id=313077
> I
> > > guess. Unlikely this patch made a difference.
> > > 
> > > I can't revert this revert; I guess I can only revert my own CLs as a
> > > mailto:non-@chromium.org user.
> > 
> > I'll do the revert of the revert.
> 
> Done in r187228.

Thanks!

Powered by Google App Engine
This is Rietveld 408576698