Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: tools/telemetry/telemetry/page/page_set.py

Issue 806513002: Move make_javascript_deterministic to UserStory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/__init__.py ('k') | tools/telemetry/telemetry/page/shared_page_state.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_set.py
diff --git a/tools/telemetry/telemetry/page/page_set.py b/tools/telemetry/telemetry/page/page_set.py
index 7a7f0e0c5f04e4613c0205156f93ae3462e84b54..a4ddc1e4206950125cceea161d2f59636235fcd0 100644
--- a/tools/telemetry/telemetry/page/page_set.py
+++ b/tools/telemetry/telemetry/page/page_set.py
@@ -21,8 +21,7 @@ class PageSetError(Exception):
class PageSet(user_story_set.UserStorySet):
def __init__(self, file_path=None, archive_data_file='', user_agent_type=None,
- make_javascript_deterministic=True, serving_dirs=None,
- bucket=None):
+ serving_dirs=None, bucket=None):
# The default value of file_path is location of the file that define this
# page set instance's class.
# TODO(chrishenry): Move this logic to user_story_set. Consider passing
@@ -41,7 +40,6 @@ class PageSet(user_story_set.UserStorySet):
# These attributes can be set dynamically by the page set.
self.user_agent_type = user_agent_type
- self.make_javascript_deterministic = make_javascript_deterministic
@property
def pages(self):
« no previous file with comments | « tools/telemetry/telemetry/page/__init__.py ('k') | tools/telemetry/telemetry/page/shared_page_state.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698