tools/telemetry/telemetry/page/__init__.py - Issue 806513002: Move make_javascript_deterministic to UserStory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/init.py

Issue 806513002: Move make_javascript_deterministic to UserStory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/__init__.py

diff --git a/tools/telemetry/telemetry/page/__init__.py b/tools/telemetry/telemetry/page/__init__.py

index f8ff78877497a5920aca4370b99438e0e7047a94..34a41d4be7cfd8871ddb967814862bcba282daff 100644

--- a/tools/telemetry/telemetry/page/__init__.py

+++ b/tools/telemetry/telemetry/page/__init__.py

@@ -24,12 +24,14 @@ def _UpdateCredentials(credentials_path):

class Page(user_story.UserStory):

def __init__(self, url, page_set=None, base_dir=None, name='',

- credentials_path=None, labels=None, startup_url=''):

+ credentials_path=None, labels=None, startup_url='',

+ make_javascript_deterministic=True):

self._url = url

super(Page, self).__init__(

shared_page_state.SharedPageState, name=name, labels=labels,

- is_local=self._scheme in ['file', 'chrome', 'about'])

+ is_local=self._scheme in ['file', 'chrome', 'about'],

+ make_javascript_deterministic=make_javascript_deterministic)

self._page_set = page_set

# Default value of base_dir is the directory of the file that defines the