Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: tools/perf/page_sets/service_worker.py

Issue 806513002: Move make_javascript_deterministic to UserStory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/alexa1-10000.py ('k') | tools/perf/page_sets/service_worker_micro_benchmark.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/service_worker.py
diff --git a/tools/perf/page_sets/service_worker.py b/tools/perf/page_sets/service_worker.py
index 2ac1c6bf9efe1c3ffc432247e631c9020f92f840..6816a7d637bc213f2594e4d0410e3db505096270 100644
--- a/tools/perf/page_sets/service_worker.py
+++ b/tools/perf/page_sets/service_worker.py
@@ -15,16 +15,18 @@ class ServiceWorkerPageSet(page_set.PageSet):
def __init__(self):
super(ServiceWorkerPageSet, self).__init__(
archive_data_file=archive_data_file_path,
- make_javascript_deterministic=False,
bucket=page_set.PARTNER_BUCKET)
# Why: the first application using ServiceWorker
# 1st time: registration
self.AddUserStory(page.Page(
- 'https://jakearchibald.github.io/trained-to-thrill/', self))
+ 'https://jakearchibald.github.io/trained-to-thrill/', self,
+ make_javascript_deterministic=False))
# 2st time: 1st onfetch with caching
self.AddUserStory(page.Page(
- 'https://jakearchibald.github.io/trained-to-thrill/', self))
+ 'https://jakearchibald.github.io/trained-to-thrill/', self,
+ make_javascript_deterministic=False))
# 3rd time: 2nd onfetch from cache
self.AddUserStory(page.Page(
- 'https://jakearchibald.github.io/trained-to-thrill/', self))
+ 'https://jakearchibald.github.io/trained-to-thrill/', self,
+ make_javascript_deterministic=False))
« no previous file with comments | « tools/perf/page_sets/alexa1-10000.py ('k') | tools/perf/page_sets/service_worker_micro_benchmark.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698