tools/perf/page_sets/service_worker_micro_benchmark.py - Issue 806513002: Move make_javascript_deterministic to UserStory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/service_worker_micro_benchmark.py

Issue 806513002: Move make_javascript_deterministic to UserStory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/service_worker_micro_benchmark.py

diff --git a/tools/perf/page_sets/service_worker_micro_benchmark.py b/tools/perf/page_sets/service_worker_micro_benchmark.py

index 6523aada82e291d7f03edde707f5d08b3168db20..24ac8d22197b60e97a35ab0df70ddf01611653ef 100644

--- a/tools/perf/page_sets/service_worker_micro_benchmark.py

+++ b/tools/perf/page_sets/service_worker_micro_benchmark.py

@@ -23,7 +23,6 @@ class ServiceWorkerMicroBenchmarkPageSet(page_set.PageSet):

def __init__(self):

super(ServiceWorkerMicroBenchmarkPageSet, self).__init__(

archive_data_file=archive_data_file_path,

- make_javascript_deterministic=False,

bucket=page_set.PUBLIC_BUCKET)

# pylint: disable=C0301

@@ -36,4 +35,5 @@ class ServiceWorkerMicroBenchmarkPageSet(page_set.PageSet):

# pylint: enable=C0301

# Why: to measure performance of many concurrent fetches

self.AddUserStory(ServiceWorkerBenchmarkPage(

- 'http://localhost:8091/index.html', self))

+ 'http://localhost:8091/index.html', self,

+ make_javascript_deterministic=False))