Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 806263002: Massive rebaseline for SkRandom. (Closed)

Created:
6 years ago by scroggo
Modified:
6 years ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Massive rebaseline for SkRandom. All of the following GMs have been switched from SkLCGRandom to SkRandom. Update their expectations for the new images. -beziers -circles -convexpaths -complexclip2 -complexclip2_rect_aa -complexclip2_rect_bw -complexclip2_path_aa -complexclip2_path_bw -complexclip2_rrect_aa -complexclip2_rrect_bw -cubicpath -cubicclosepath -degeneratesegments -emptypath -getpostextpath -hittestpath -linepath -lineclosepath -points -polygons -quadpath -quadclosepath -strokerects -strokes_round -strokes_poly BUG=skia:3241 TBR=mtklein Committed: https://skia.googlesource.com/skia/+/41b4d77d02ee8844a8f4c6a806495614ef78b0a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4523 lines, -6609 lines) Patch
M expectations/gm/Test-Android-GalaxyS4-SGX544-Arm7-Debug/expected-results.json View 18 chunks +19 lines, -19 lines 0 comments Download
M expectations/gm/Test-Android-GalaxyS4-SGX544-Arm7-Release/expected-results.json View 18 chunks +19 lines, -19 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Debug/expected-results.json View 32 chunks +80 lines, -125 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json View 32 chunks +80 lines, -125 lines 0 comments Download
M expectations/gm/Test-Android-Nexus5-Adreno330-Arm7-Debug/expected-results.json View 29 chunks +82 lines, -166 lines 0 comments Download
M expectations/gm/Test-Android-Nexus5-Adreno330-Arm7-Release/expected-results.json View 29 chunks +82 lines, -166 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Debug/expected-results.json View 29 chunks +102 lines, -91 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Release/expected-results.json View 29 chunks +102 lines, -91 lines 0 comments Download
M expectations/gm/Test-Android-Nexus9-TegraK1-Arm64-Debug/expected-results.json View 77 chunks +110 lines, -110 lines 0 comments Download
M expectations/gm/Test-Android-Nexus9-TegraK1-Arm64-Release/expected-results.json View 77 chunks +110 lines, -110 lines 0 comments Download
M expectations/gm/Test-Android-NexusPlayer-PowerVR-x86-Release/expected-results.json View 54 chunks +54 lines, -54 lines 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Debug/expected-results.json View 29 chunks +102 lines, -91 lines 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Release/expected-results.json View 29 chunks +102 lines, -91 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Debug/expected-results.json View 21 chunks +60 lines, -120 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json View 21 chunks +60 lines, -120 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/expected-results.json View 19 chunks +62 lines, -128 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Release/expected-results.json View 19 chunks +62 lines, -128 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Debug/expected-results.json View 19 chunks +62 lines, -128 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Release/expected-results.json View 19 chunks +62 lines, -128 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 46 chunks +143 lines, -122 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 43 chunks +143 lines, -122 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 43 chunks +148 lines, -135 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 40 chunks +148 lines, -135 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 38 chunks +117 lines, -228 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 42 chunks +144 lines, -255 lines 0 comments Download
M expectations/gm/Test-Mac10.9-MacMini6.2-HD4000-x86_64-Debug/expected-results.json View 45 chunks +105 lines, -180 lines 0 comments Download
M expectations/gm/Test-Mac10.9-MacMini6.2-HD4000-x86_64-Release/expected-results.json View 46 chunks +105 lines, -180 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json View 55 chunks +182 lines, -275 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/expected-results.json View 56 chunks +181 lines, -274 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 51 chunks +188 lines, -285 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release/expected-results.json View 51 chunks +188 lines, -288 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json View 18 chunks +31 lines, -25 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 33 chunks +96 lines, -84 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json View 18 chunks +31 lines, -25 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 37 chunks +67 lines, -124 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json View 31 chunks +100 lines, -86 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json View 31 chunks +100 lines, -86 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Debug/expected-results.json View 50 chunks +136 lines, -241 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Release/expected-results.json View 50 chunks +136 lines, -241 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 50 chunks +136 lines, -241 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Release/expected-results.json View 50 chunks +136 lines, -241 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86-Debug/expected-results.json View 35 chunks +92 lines, -179 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86-Release/expected-results.json View 29 chunks +86 lines, -173 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86_64-Debug/expected-results.json View 29 chunks +86 lines, -173 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86_64-Release/expected-results.json View 29 chunks +86 lines, -173 lines 0 comments Download
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806263002/1
6 years ago (2014-12-16 18:51:01 UTC) #2
mtklein
LGTM. These new hashes look SO good to me.
6 years ago (2014-12-16 18:53:53 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-16 19:00:04 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/41b4d77d02ee8844a8f4c6a806495614ef78b0a8

Powered by Google App Engine
This is Rietveld 408576698