Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 80623002: Array builtins proceed blithely on frozen arrays (Closed)

Created:
7 years, 1 month ago by mvstanton
Modified:
7 years ago
Reviewers:
Toon Verwaest, rossberg
CC:
v8-dev
Visibility:
Public.

Description

Array builtins need to be prevented from changing frozen objects, and changing structure on sealed objects. BUG=299979 LOG=Y R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18164

Patch Set 1 #

Patch Set 2 : Added tests and checks in custom built-in compilers. #

Patch Set 3 : Changed to use sealed. #

Patch Set 4 : Platform ports. #

Patch Set 5 : REBASE #

Patch Set 6 : a.unshift() needed special care. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -37 lines) Patch
M src/arm/stub-cache-arm.cc View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download
M src/array.js View 1 2 3 4 5 6 chunks +47 lines, -7 lines 0 comments Download
M src/builtins.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download
M src/messages.js View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download
M src/objects-printer.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 2 3 4 2 chunks +8 lines, -12 lines 0 comments Download
M test/mjsunit/object-freeze.js View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
M test/mjsunit/object-seal.js View 1 2 3 4 5 2 chunks +76 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-2711.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-299979.js View 1 2 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mvstanton
Hi guys, PTAL. Thanks, --Michael
7 years ago (2013-11-21 13:35:55 UTC) #1
Toon Verwaest
I think we should check for sealed objects, not frozen.
7 years ago (2013-11-21 13:44:02 UTC) #2
mvstanton
Hi, I've updated to rely on sealed, only paying attention to frozen in array.splice(), where ...
7 years ago (2013-11-25 15:50:15 UTC) #3
Toon Verwaest
Looking good. Go ahead with the platform ports.
7 years ago (2013-11-25 16:01:10 UTC) #4
mvstanton
Okay, here are the ports, thanks! --michael
7 years ago (2013-11-25 20:28:01 UTC) #5
Toon Verwaest
lgtm
7 years ago (2013-11-28 19:06:27 UTC) #6
mvstanton
7 years ago (2013-11-29 15:22:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #6 manually as r18164 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698