src/builtins.cc - Issue 80623002: Array builtins proceed blithely on frozen arrays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 80623002: Array builtins proceed blithely on frozen arrays (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: a.unshift() needed special care. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index 62e4372d0e7b579d5fd726becec9fc80aa065ed4..538b657f2fe9937bd2315aba2ac56d3fded14de0 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -312,6 +312,7 @@ static inline MaybeObject* EnsureJSArrayWithWritableFastElements(

if (!receiver->IsJSArray()) return NULL;

JSArray* array = JSArray::cast(receiver);

if (array->map()->is_observed()) return NULL;

+ if (!array->map()->is_extensible()) return NULL;

HeapObject* elms = array->elements();

Map* map = elms->map();

if (map == heap->fixed_array_map()) {

« no previous file with comments | « src/array.js ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »