Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: Source/core/frame/Frame.h

Issue 806183005: Remove FrameLoader's checkLoadComplete and checkLoadCompleteForThisFrame (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/fetch/ResourceFetcher.cpp ('k') | Source/core/frame/LocalFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/Frame.h
diff --git a/Source/core/frame/Frame.h b/Source/core/frame/Frame.h
index 8e587c593a3d47ee74572fb477c064f8f936c0a1..4a8be87fa4c3aab222d00119056a889b39ad5863 100644
--- a/Source/core/frame/Frame.h
+++ b/Source/core/frame/Frame.h
@@ -108,14 +108,13 @@ public:
// method.
bool isRemoteFrameTemporary() const { return m_remotePlatformLayer; }
- virtual bool checkLoadComplete() = 0;
-
// isLoading() is true when the embedder should think a load is in progress.
// In the case of LocalFrames, it means that the frame has sent a didStartLoading()
// callback, but not the matching didStopLoading(). Inside blink, you probably
// want Document::loadEventFinished() instead.
void setIsLoading(bool isLoading) { m_isLoading = isLoading; }
bool isLoading() const { return m_isLoading; }
+ virtual bool isLoadingAsChild() const { return isLoading(); }
dcheng 2015/01/13 22:18:55 Hmm. I think in the long-term, we should hide thes
protected:
Frame(FrameClient*, FrameHost*, FrameOwner*);
« no previous file with comments | « Source/core/fetch/ResourceFetcher.cpp ('k') | Source/core/frame/LocalFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698