Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: Source/core/frame/Frame.h

Issue 806183005: Remove FrameLoader's checkLoadComplete and checkLoadCompleteForThisFrame (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/fetch/ResourceFetcher.cpp ('k') | Source/core/frame/LocalFrame.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 WebLayer* remotePlatformLayer() const { return m_remotePlatformLayer; } 101 WebLayer* remotePlatformLayer() const { return m_remotePlatformLayer; }
102 102
103 Settings* settings() const; // can be null 103 Settings* settings() const; // can be null
104 104
105 // FIXME: This method identifies a LocalFrame that is acting as a RemoteFram e. 105 // FIXME: This method identifies a LocalFrame that is acting as a RemoteFram e.
106 // It is necessary only until we can instantiate a RemoteFrame, at which poi nt 106 // It is necessary only until we can instantiate a RemoteFrame, at which poi nt
107 // it can be removed and its callers can be converted to use the isRemoteFra me() 107 // it can be removed and its callers can be converted to use the isRemoteFra me()
108 // method. 108 // method.
109 bool isRemoteFrameTemporary() const { return m_remotePlatformLayer; } 109 bool isRemoteFrameTemporary() const { return m_remotePlatformLayer; }
110 110
111 virtual bool checkLoadComplete() = 0;
112
113 // isLoading() is true when the embedder should think a load is in progress. 111 // isLoading() is true when the embedder should think a load is in progress.
114 // In the case of LocalFrames, it means that the frame has sent a didStartLo ading() 112 // In the case of LocalFrames, it means that the frame has sent a didStartLo ading()
115 // callback, but not the matching didStopLoading(). Inside blink, you probab ly 113 // callback, but not the matching didStopLoading(). Inside blink, you probab ly
116 // want Document::loadEventFinished() instead. 114 // want Document::loadEventFinished() instead.
117 void setIsLoading(bool isLoading) { m_isLoading = isLoading; } 115 void setIsLoading(bool isLoading) { m_isLoading = isLoading; }
118 bool isLoading() const { return m_isLoading; } 116 bool isLoading() const { return m_isLoading; }
117 virtual bool isLoadingAsChild() const { return isLoading(); }
dcheng 2015/01/13 22:18:55 Hmm. I think in the long-term, we should hide thes
119 118
120 protected: 119 protected:
121 Frame(FrameClient*, FrameHost*, FrameOwner*); 120 Frame(FrameClient*, FrameHost*, FrameOwner*);
122 121
123 mutable FrameTree m_treeNode; 122 mutable FrameTree m_treeNode;
124 123
125 RawPtrWillBeMember<FrameHost> m_host; 124 RawPtrWillBeMember<FrameHost> m_host;
126 RawPtrWillBeMember<FrameOwner> m_owner; 125 RawPtrWillBeMember<FrameOwner> m_owner;
127 126
128 private: 127 private:
(...skipping 17 matching lines...) Expand all
146 { 145 {
147 return m_treeNode; 146 return m_treeNode;
148 } 147 }
149 148
150 // Allow equality comparisons of Frames by reference or pointer, interchangeably . 149 // Allow equality comparisons of Frames by reference or pointer, interchangeably .
151 DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES_REFCOUNTED(Frame) 150 DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES_REFCOUNTED(Frame)
152 151
153 } // namespace blink 152 } // namespace blink
154 153
155 #endif // Frame_h 154 #endif // Frame_h
OLDNEW
« no previous file with comments | « Source/core/fetch/ResourceFetcher.cpp ('k') | Source/core/frame/LocalFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698