Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: sky/tests/framework/templates.sky

Issue 806133003: Fix detached callback and add isAttached to SkyElements. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Don't hide state for now. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/framework/sky-element/sky-element.sky ('k') | sky/tests/framework/templates-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tests/framework/templates.sky
diff --git a/sky/tests/framework/templates.sky b/sky/tests/framework/templates.sky
index 30e119fc41245eef95441152d2515a3c1a8106b2..040a9e41ab13b6d160fecb5fb9059a9b5acb27c5 100644
--- a/sky/tests/framework/templates.sky
+++ b/sky/tests/framework/templates.sky
@@ -24,6 +24,14 @@ describe("SkyElement templates", function() {
assert.ok(element.shadowRoot.getElementById("inside"));
});
+ it("should update isAttached when inserting", function() {
+ assert.isFalse(element.isAttached);
+ sandbox.appendChild(element);
+ assert.isTrue(element.isAttached);
+ element.remove();
+ assert.isFalse(element.isAttached);
+ });
+
it("should connect data binding", function(done) {
sandbox.appendChild(element);
var inside = element.shadowRoot.getElementById("inside");
« no previous file with comments | « sky/framework/sky-element/sky-element.sky ('k') | sky/tests/framework/templates-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698