Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: sky/framework/sky-element/sky-element.sky

Issue 806133003: Fix detached callback and add isAttached to SkyElements. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Don't hide state for now. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/tests/framework/templates.sky » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/sky-element/sky-element.sky
diff --git a/sky/framework/sky-element/sky-element.sky b/sky/framework/sky-element/sky-element.sky
index d34ce56b9a818c123ccb05b98a9f8ac9f35b021c..a6202df2763e4ac3f4e2fb2586f92bd05f068865 100644
--- a/sky/framework/sky-element/sky-element.sky
+++ b/sky/framework/sky-element/sky-element.sky
@@ -36,7 +36,7 @@ class SkyElement extends HTMLElement {
// override
}
- dettached() {
+ detached() {
// override
}
@@ -49,6 +49,7 @@ class SkyElement extends HTMLElement {
}
createdCallback() {
+ this.isAttached = false;
this.created();
}
@@ -63,10 +64,12 @@ class SkyElement extends HTMLElement {
}
}
this.attached();
+ this.isAttached = true;
}
- dettachedCallback() {
- this.dettached();
+ detachedCallback() {
+ this.detached();
+ this.isAttached = false;
}
attributeChangedCallback(attrName, oldValue, newValue) {
« no previous file with comments | « no previous file | sky/tests/framework/templates.sky » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698