Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 8060045: Use shared D3D9 texture to transport the compositor's backing buffer to the browser... (Closed)

Created:
9 years, 2 months ago by apatrick_chromium
Modified:
9 years, 1 month ago
CC:
chromium-reviews, dpranke+watch-content_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Use shared D3D9 texture to transport the compositor's backing buffer to the browser process for presentation. Implemented ImageTransportSurface for Linux (without texture sharing), XP, Vista and 7. XP. The non-texture sharing Linux and XP paths just present directly to the compositing child window owned by the browser process as before. PassThroughImageTransportSurface still needs a proper name. I will move it into its own file once that is decided. I moved AcceleratedSurfaceBuffersSwapped outside of the platform specific ifdefs and made the signature the same on all platforms for greater consistency. I removed the code related to sharing surfaces between processes and synchronizing resize and swapping out of GpuCommandBufferStub. It is all now in ImageTransportSurface implementations. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110355

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Patch Set 11 : '' #

Patch Set 12 : '' #

Patch Set 13 : '' #

Patch Set 14 : '' #

Patch Set 15 : '' #

Total comments: 1

Patch Set 16 : '' #

Total comments: 26

Patch Set 17 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+560 lines, -275 lines) Patch
M chrome/browser/renderer_host/render_widget_host_view_views.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_views.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +14 lines, -5 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +4 lines, -8 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 5 chunks +10 lines, -21 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_mac.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 4 chunks +11 lines, -15 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +26 lines, -22 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +8 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +8 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 7 chunks +53 lines, -2 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +3 lines, -6 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +5 lines, -8 lines 0 comments Download
M content/common/gpu/gpu_channel.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +0 lines, -8 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +1 line, -13 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +3 lines, -13 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 7 chunks +16 lines, -72 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 5 chunks +12 lines, -43 lines 0 comments Download
M content/common/gpu/image_transport_surface.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 6 chunks +46 lines, -0 lines 0 comments Download
M content/common/gpu/image_transport_surface.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 6 chunks +94 lines, -0 lines 0 comments Download
M content/common/gpu/image_transport_surface_linux.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 8 chunks +29 lines, -1 line 0 comments Download
M content/common/gpu/image_transport_surface_mac.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 4 chunks +10 lines, -0 lines 0 comments Download
A content/common/gpu/image_transport_surface_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +175 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
apatrick_chromium
This is going to take a few iterations but I think its ready to start ...
9 years, 2 months ago (2011-10-20 22:29:47 UTC) #1
apatrick_chromium
http://codereview.chromium.org/8060045/diff/48006/gpu/DEPS File gpu/DEPS (left): http://codereview.chromium.org/8060045/diff/48006/gpu/DEPS#oldcode2 gpu/DEPS:2: "+webkit/glue/plugins", Don't know why this is in here. Will ...
9 years, 2 months ago (2011-10-20 22:30:27 UTC) #2
apatrick_chromium
I pared this patch back to the essentials and split out independent parts into new ...
9 years, 1 month ago (2011-11-03 20:55:20 UTC) #3
jonathan.backer
SG. Mostly nits. http://codereview.chromium.org/8060045/diff/59001/chrome/browser/renderer_host/render_widget_host_view_views.cc File chrome/browser/renderer_host/render_widget_host_view_views.cc (right): http://codereview.chromium.org/8060045/diff/59001/chrome/browser/renderer_host/render_widget_host_view_views.cc#newcode1181 chrome/browser/renderer_host/render_widget_host_view_views.cc:1181: int gpu_host_id) { NOTREACHED() http://codereview.chromium.org/8060045/diff/59001/content/browser/renderer_host/render_widget_host_view.h File ...
9 years, 1 month ago (2011-11-03 23:09:07 UTC) #4
apatrick_chromium
Sorry for rebasing. I think I addressed everything. Hopefully we can avoid a lot of ...
9 years, 1 month ago (2011-11-07 20:40:04 UTC) #5
jonathan.backer
lgtm
9 years, 1 month ago (2011-11-07 22:47:41 UTC) #6
jonathan.backer
On 2011/11/07 22:47:41, jonathan.backer wrote: > lgtm Works on touchui=1. Thanks for the wait.
9 years, 1 month ago (2011-11-08 13:32:50 UTC) #7
apatrick_chromium
+darin for content/browser.
9 years, 1 month ago (2011-11-08 20:42:27 UTC) #8
apatrick_chromium
On 2011/11/08 20:42:27, apatrick_chromium wrote: > +darin for content/browser. darin, ping :)
9 years, 1 month ago (2011-11-09 19:11:36 UTC) #9
apatrick_chromium
ben, can you take a look at this for content/browser for owners? darin is busy.
9 years, 1 month ago (2011-11-16 00:03:50 UTC) #10
Ben Goodger (Google)
9 years, 1 month ago (2011-11-16 16:35:54 UTC) #11
lgtm

Powered by Google App Engine
This is Rietveld 408576698