Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 805983003: Use SkPaint::getFontBounds() for text bounding boxes in pictures. (Closed)

Created:
6 years ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use SkPaint::getFontBounds() for text bounding boxes in pictures. Now that SkTextBlobs have landed, this is a perf no-op, but it at least lets us eliminate a bunch of questionable hacks. CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot,Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug-Trybot,Test-Win7-ShuttleA-HD2000-x86-Debug-GDI-Trybot GDI: -996.826172 -1508.789063 3000.000000 487.060547 vs. -1007.812500 -1500.000000 3000.000000 492.187500 BUG=skia: Committed: https://skia.googlesource.com/skia/+/02d2b9831579173e783569530ab7bae08de907e9 COMMIT=false

Patch Set 1 #

Patch Set 2 : another 2%, more verbose assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -30 lines) Patch
M src/core/SkPaint.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/core/SkRecordDraw.cpp View 1 2 chunks +18 lines, -24 lines 0 comments Download
M tests/RecordDrawTest.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805983003/1
6 years ago (2014-12-15 21:51:43 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-15 21:51:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805983003/1
6 years ago (2014-12-15 23:57:36 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-15 23:57:36 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years ago (2014-12-16 05:57:45 UTC) #9
reed1
lgtm
6 years ago (2014-12-16 13:49:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805983003/1
6 years ago (2014-12-16 14:17:44 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/02d2b9831579173e783569530ab7bae08de907e9
6 years ago (2014-12-16 14:17:58 UTC) #14
mtklein
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/789793004/ by mtklein@google.com. ...
6 years ago (2014-12-16 14:30:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805983003/20001
6 years ago (2014-12-16 16:00:40 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug-Trybot/builds/41)
6 years ago (2014-12-16 18:13:42 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805983003/20001
6 years ago (2014-12-16 18:26:51 UTC) #21
commit-bot: I haz the power
6 years ago (2014-12-16 20:26:25 UTC) #23
Try jobs failed on following builders:
  Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug-Trybot on client.skia
(http://build.chromium.org/p/client.skia/builders/Test-Mac10.8-MacMini4.1-GeFo...)

Powered by Google App Engine
This is Rietveld 408576698