There can be only one (SkRandom)!

There can be only one (SkRandom)!

Remove SkLCGRandom. We already decided the new one was better, which is
why we wrote the new SkRandom.

Convert GMs that were using SkLCGRandom to use the improved SkRandom.
Motivated by the fact that these GMs draw differently on some runs. We
believe this to be a result of using the old SkLCGRandom.

Add each of the tests that were using SkLCGRandom to ignore-tests.txt,
since we expect they'll draw differently using SkRandom.

Move a trimmed down version of SkLCGRandom into SkDiscretePathEffect.
In order to preserve the old behavior, trim down SkLCGRandom to only
the methods used by SkDiscretePathEffect, and hide it in
SkDiscretePathEffect's cpp file.

BUG=skia:3241
Committed: https://skia.googlesource.com/skia/+/f9d610179d7d4198b57b12d06f8d1ca09f580df3

[scroggo, 2014-12-15 19:21:59]

scroggo@google.com changed reviewers:
+ reed@google.com

[reed1, 2014-12-15 19:36:49]

reed@google.com changed reviewers:
+ jvanverth@google.com, robertphillips@google.com

[reed1, 2014-12-15 19:36:49]

lgtm

[jvanverth1, 2014-12-15 19:43:37]

On 2014/12/15 19:36:49, reed1 wrote:
> lgtm

lgtm 2

[scroggo, 2014-12-15 20:12:33]

On 2014/12/15 19:43:37, jvanverth1 wrote:
> On 2014/12/15 19:36:49, reed1 wrote:
> > lgtm
> 
> lgtm 2

Robert (or anyone on skia-reviews) want to chime in?

[robertphillips, 2014-12-15 20:38:36]

lgtm

[scroggo, 2014-12-15 20:39:06]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2014-12-15 20:39:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/805963002/20001

[commit-bot: I haz the power, 2014-12-15 20:39:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-15 20:39:32]

Failed to apply patch for expectations/gm/ignored-tests.txt:
While running git apply --index -3 -p1;
  error: patch failed: expectations/gm/ignored-tests.txt:59
  Falling back to three-way merge...
  Applied patch to 'expectations/gm/ignored-tests.txt' with conflicts.
  U expectations/gm/ignored-tests.txt

Patch:       expectations/gm/ignored-tests.txt
Index: expectations/gm/ignored-tests.txt
diff --git a/expectations/gm/ignored-tests.txt
b/expectations/gm/ignored-tests.txt
index
44577413b8d373cd3f98a0e6e7d40e498e2163a8..eb7609f07ce6fa67f760ec45d902f1c6ee5f3b56
100644
--- a/expectations/gm/ignored-tests.txt
+++ b/expectations/gm/ignored-tests.txt
@@ -59,3 +59,30 @@ drawbitmapmatrix
 
 #junov skbug.com/3176
 pictureimagefilter
+
+#scroggo skbug.com/3241
+# replacing SkLCGRandom with SkRandom
+beziers
+circles
+complexclip2
+complexclip2_rect_aa
+complexclip2_rect_bw
+complexclip2_path_aa
+complexclip2_path_bw
+complexclip2_rrect_aa
+complexclip2_rrect_bw
+cubicpath
+cubicclosepath
+degeneratesegments
+emptypath
+getpostextpath
+hittestpath
+linepath
+lineclosepath
+points
+polygons
+quadpath
+quadclosepath
+strokerects
+strokes_round
+strokes_poly

[scroggo, 2014-12-15 20:43:45]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2014-12-15 20:44:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/805963002/40001

[commit-bot: I haz the power, 2014-12-15 20:54:56]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f9d610179d7d4198b57b12d06f8d1ca09f580df3