Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1790)

Unified Diff: chrome/browser/signin/android_profile_oauth2_token_service.cc

Issue 805903005: Move WeakPtrFactory members to the end in some android code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/compositor/tab_content_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/android_profile_oauth2_token_service.cc
diff --git a/chrome/browser/signin/android_profile_oauth2_token_service.cc b/chrome/browser/signin/android_profile_oauth2_token_service.cc
index 135857bb8dadd58bcd58022f3c300eeb856826dd..abccb277a31dcb1f216406ccf66ad86fb47c474c 100644
--- a/chrome/browser/signin/android_profile_oauth2_token_service.cc
+++ b/chrome/browser/signin/android_profile_oauth2_token_service.cc
@@ -55,9 +55,9 @@ class AndroidAccessTokenFetcher : public OAuth2AccessTokenFetcher {
private:
std::string CombineScopes(const std::vector<std::string>& scopes);
- base::WeakPtrFactory<AndroidAccessTokenFetcher> weak_factory_;
std::string account_id_;
bool request_was_cancelled_;
+ base::WeakPtrFactory<AndroidAccessTokenFetcher> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(AndroidAccessTokenFetcher);
};
@@ -66,9 +66,9 @@ AndroidAccessTokenFetcher::AndroidAccessTokenFetcher(
OAuth2AccessTokenConsumer* consumer,
const std::string& account_id)
: OAuth2AccessTokenFetcher(consumer),
- weak_factory_(this),
account_id_(account_id),
- request_was_cancelled_(false) {
+ request_was_cancelled_(false),
+ weak_factory_(this) {
}
AndroidAccessTokenFetcher::~AndroidAccessTokenFetcher() {}
« no previous file with comments | « chrome/browser/android/compositor/tab_content_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698