chrome/browser/android/compositor/tab_content_manager.cc - Issue 805903005: Move WeakPtrFactory members to the end in some android code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/compositor/tab_content_manager.cc

Issue 805903005: Move WeakPtrFactory members to the end in some android code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/compositor/tab_content_manager.h ('k') | chrome/browser/signin/android_profile_oauth2_token_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/compositor/tab_content_manager.cc

diff --git a/chrome/browser/android/compositor/tab_content_manager.cc b/chrome/browser/android/compositor/tab_content_manager.cc

index 3fb438b6fc7e4138265e96bc61bf783ecbcce24e..8b64ff2b06e0171a75af85cbd9b7ad20d37f7330 100644

--- a/chrome/browser/android/compositor/tab_content_manager.cc

+++ b/chrome/browser/android/compositor/tab_content_manager.cc

@@ -135,7 +135,7 @@ TabContentManager::TabContentManager(JNIEnv* env,

jint compression_queue_max_size,

jint write_queue_max_size,

jboolean use_approximation_thumbnail)

- : weak_factory_(this), weak_java_tab_content_manager_(env, obj) {

+ : weak_java_tab_content_manager_(env, obj), weak_factory_(this) {

std::string disk_cache_path_str =

base::android::ConvertJavaStringToUTF8(env, disk_cache_path);

thumbnail_cache_ = make_scoped_ptr(new ThumbnailCache(