Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 805903005: Move WeakPtrFactory members to the end in some android code (Closed)

Created:
5 years, 11 months ago by dmichael (off chromium)
Modified:
5 years, 11 months ago
Reviewers:
bbudge, boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WeakPtrFactory members to the end in some android code This forces WeakPtrs to be invalidated before other members' destructors run. See the bug or the documentation of WeakPtrFactory for more information. I'm in the process of trying to turn on a clang check for this (see the bug). BUG=303818 TBR=yfriedman@chromium.org,boliu@chromium.org,tim@chromium.org Committed: https://crrev.com/2d1046b2ca5c18fa03cfa2f08708bbd3be98dbdb Cr-Commit-Position: refs/heads/master@{#311716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M android_webview/renderer/print_web_view_helper.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/android/compositor/tab_content_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/compositor/tab_content_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/android_profile_oauth2_token_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dmichael (off chromium)
Mind taking a quick look? This should be the last bunch of WeakPtrFactory mistakes I ...
5 years, 11 months ago (2015-01-15 18:42:56 UTC) #2
boliu
android_webview lgtm
5 years, 11 months ago (2015-01-15 18:48:48 UTC) #4
bbudge
lgtm
5 years, 11 months ago (2015-01-15 19:07:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805903005/1
5 years, 11 months ago (2015-01-15 19:09:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 19:52:20 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 19:54:30 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d1046b2ca5c18fa03cfa2f08708bbd3be98dbdb
Cr-Commit-Position: refs/heads/master@{#311716}

Powered by Google App Engine
This is Rietveld 408576698