Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 805823002: Remove code duplication from the customCSSText() methods of gradient classes. (Closed)

Created:
6 years ago by reni
Modified:
6 years ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis, Mike West, Erik Corry
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove code duplication from the customCSSText() methods of gradient classes. CSSRadialGradientValue::customCSSText and CSSLinearGradientValue::customCSSText use the same code for building custom text for color stops. Moving this code into an own method we can eliminate the code duplication. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187559

Patch Set 1 #

Patch Set 2 : Rename the new method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -41 lines) Patch
M Source/core/css/CSSGradientValue.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSGradientValue.cpp View 1 3 chunks +25 lines, -41 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
reni
The failing bots seem to be unrelated to this change.
6 years ago (2014-12-15 17:01:14 UTC) #1
reni
@timloh: could you take a look at this please?
6 years ago (2014-12-16 19:14:36 UTC) #3
Timothy Loh
On 2014/12/16 19:14:36, reni wrote: > @timloh: could you take a look at this please? ...
6 years ago (2014-12-18 23:04:50 UTC) #4
reni
On 2014/12/18 23:04:50, Timothy Loh (OOO until 5th) wrote: > On 2014/12/16 19:14:36, reni wrote: ...
6 years ago (2014-12-19 18:35:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805823002/20001
6 years ago (2014-12-19 18:36:23 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-19 20:19:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187559

Powered by Google App Engine
This is Rietveld 408576698