Remove code duplication from the customCSSText() methods of gradient classes.

Source/core/css/CSSGradientValue.cpp

 /*
  * Copyright (C) 2008 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 560 matching lines @@
     StringBuilder result;
     if (m_gradientType == CSSDeprecatedLinearGradient) {
         result.appendLiteral("-webkit-gradient(linear, ");
         result.append(m_firstX->cssText());
         result.append(' ');
         result.append(m_firstY->cssText());
         result.appendLiteral(", ");
         result.append(m_secondX->cssText());
         result.append(' ');
         result.append(m_secondY->cssText());
-
-        for (unsigned i = 0; i < m_stops.size(); i++) {
-            const CSSGradientColorStop& stop = m_stops[i];
-            result.appendLiteral(", ");
-            if (stop.m_position->getDoubleValue(CSSPrimitiveValue::CSS_NUMBER) == 0) {
-                result.appendLiteral("from(");
-                result.append(stop.m_color->cssText());
-                result.append(')');
-            } else if (stop.m_position->getDoubleValue(CSSPrimitiveValue::CSS_NUMBER) == 1) {
-                result.appendLiteral("to(");
-                result.append(stop.m_color->cssText());
-                result.append(')');
-            } else {
-                result.appendLiteral("color-stop(");
-                result.appendNumber(stop.m_position->getDoubleValue(CSSPrimitiveValue::CSS_NUMBER));
-                result.appendLiteral(", ");
-                result.append(stop.m_color->cssText());
-                result.append(')');
-            }
-        }
+        appendCSSTextForDeprecatedColorStops(result);
     } else if (m_gradientType == CSSPrefixedLinearGradient) {
         if (m_repeating)
             result.appendLiteral("-webkit-repeating-linear-gradient(");
         else
             result.appendLiteral("-webkit-linear-gradient(");
 
         if (m_angle)
             result.append(m_angle->cssText());
         else {
             if (m_firstX && m_firstY) {
@@ skipping 228 matching lines @@
 
     return equalXandY && m_stops == other.m_stops;
 }
 
 void CSSLinearGradientValue::traceAfterDispatch(Visitor* visitor)
 {
     visitor->trace(m_angle);
     CSSGradientValue::traceAfterDispatch(visitor);
 }
 
+inline void CSSGradientValue::appendCSSTextForDeprecatedColorStops(StringBuilder& result) const
+{
+    for (unsigned i = 0; i < m_stops.size(); i++) {
+        const CSSGradientColorStop& stop = m_stops[i];
+        result.appendLiteral(", ");
+        if (stop.m_position->getDoubleValue(CSSPrimitiveValue::CSS_NUMBER) == 0) {
+            result.appendLiteral("from(");
+            result.append(stop.m_color->cssText());
+            result.append(')');
+        } else if (stop.m_position->getDoubleValue(CSSPrimitiveValue::CSS_NUMBER) == 1) {
+            result.appendLiteral("to(");
+            result.append(stop.m_color->cssText());
+            result.append(')');
+        } else {
+            result.appendLiteral("color-stop(");
+            result.appendNumber(stop.m_position->getDoubleValue(CSSPrimitiveValue::CSS_NUMBER));
+            result.appendLiteral(", ");
+            result.append(stop.m_color->cssText());
+            result.append(')');
+        }
+    }
+}
+
 String CSSRadialGradientValue::customCSSText() const
 {
     StringBuilder result;
 
     if (m_gradientType == CSSDeprecatedRadialGradient) {
         result.appendLiteral("-webkit-gradient(radial, ");
         result.append(m_firstX->cssText());
         result.append(' ');
         result.append(m_firstY->cssText());
         result.appendLiteral(", ");
         result.append(m_firstRadius->cssText());
         result.appendLiteral(", ");
         result.append(m_secondX->cssText());
         result.append(' ');
         result.append(m_secondY->cssText());
         result.appendLiteral(", ");
         result.append(m_secondRadius->cssText());
-
-        // FIXME: share?
-        for (unsigned i = 0; i < m_stops.size(); i++) {
-            const CSSGradientColorStop& stop = m_stops[i];
-            result.appendLiteral(", ");
-            if (stop.m_position->getDoubleValue(CSSPrimitiveValue::CSS_NUMBER) == 0) {
-                result.appendLiteral("from(");
-                result.append(stop.m_color->cssText());
-                result.append(')');
-            } else if (stop.m_position->getDoubleValue(CSSPrimitiveValue::CSS_NUMBER) == 1) {
-                result.appendLiteral("to(");
-                result.append(stop.m_color->cssText());
-                result.append(')');
-            } else {
-                result.appendLiteral("color-stop(");
-                result.appendNumber(stop.m_position->getDoubleValue(CSSPrimitiveValue::CSS_NUMBER));
-                result.appendLiteral(", ");
-                result.append(stop.m_color->cssText());
-                result.append(')');
-            }
-        }
+        appendCSSTextForDeprecatedColorStops(result);
     } else if (m_gradientType == CSSPrefixedRadialGradient) {
         if (m_repeating)
             result.appendLiteral("-webkit-repeating-radial-gradient(");
         else
             result.appendLiteral("-webkit-radial-gradient(");
 
         if (m_firstX && m_firstY) {
             result.append(m_firstX->cssText());
             result.append(' ');
             result.append(m_firstY->cssText());
@@ skipping 383 matching lines @@
     visitor->trace(m_firstRadius);
     visitor->trace(m_secondRadius);
     visitor->trace(m_shape);
     visitor->trace(m_sizingBehavior);
     visitor->trace(m_endHorizontalSize);
     visitor->trace(m_endVerticalSize);
     CSSGradientValue::traceAfterDispatch(visitor);
 }
 
 } // namespace blink