Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 805483002: Removed references to mac_gpu, which has been removed (Closed)

Created:
6 years ago by Sergiy Byelozyorov
Modified:
6 years ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed references to mac_gpu, which has been removed BUG=426897 R=kbr@chromium.org,phajdan.jr@chromium.org,zmo@chromium.org Committed: https://crrev.com/2adbe15c19c12ed068924813f98621a08326441e Cr-Commit-Position: refs/heads/master@{#308995}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M PRESUBMIT.py View 1 3 chunks +0 lines, -3 lines 0 comments Download
M PRESUBMIT_test.py View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 25 (8 generated)
Sergiy Byelozyorov
6 years ago (2014-12-12 16:49:48 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years ago (2014-12-12 17:45:06 UTC) #2
Zhenyao Mo
LGTM
6 years ago (2014-12-12 17:49:20 UTC) #3
Ken Russell (switch to Gerrit)
LGTM with this question answered. https://codereview.chromium.org/805483002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/805483002/diff/1/PRESUBMIT.py#newcode1706 PRESUBMIT.py:1706: 'mac_chromium_rel_ng': ['defaulttests'], Same question ...
6 years ago (2014-12-12 18:47:47 UTC) #4
Sergiy Byelozyorov
https://codereview.chromium.org/805483002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/805483002/diff/1/PRESUBMIT.py#newcode1706 PRESUBMIT.py:1706: 'mac_chromium_rel_ng': ['defaulttests'], On 2014/12/12 18:47:47, Ken Russell wrote: > ...
6 years ago (2014-12-15 16:00:23 UTC) #5
Paweł Hajdan Jr.
https://codereview.chromium.org/805483002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/805483002/diff/1/PRESUBMIT.py#newcode1706 PRESUBMIT.py:1706: 'mac_chromium_rel_ng': ['defaulttests'], On 2014/12/15 16:00:23, Sergiy Byelozyorov wrote: > ...
6 years ago (2014-12-15 16:01:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805483002/1
6 years ago (2014-12-15 16:02:58 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/30487)
6 years ago (2014-12-15 16:07:27 UTC) #10
Ken Russell (switch to Gerrit)
piman, sievers: OWNERS review of gpu/PRESUBMIT.py please.
6 years ago (2014-12-15 19:07:36 UTC) #12
piman
lgtm
6 years ago (2014-12-15 19:09:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805483002/1
6 years ago (2014-12-15 19:11:40 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/30541)
6 years ago (2014-12-15 19:18:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805483002/1
6 years ago (2014-12-18 11:03:01 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_rel/builds/1356)
6 years ago (2014-12-18 11:08:01 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805483002/20001
6 years ago (2014-12-18 11:26:34 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-18 12:21:32 UTC) #24
commit-bot: I haz the power
6 years ago (2014-12-18 12:22:14 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2adbe15c19c12ed068924813f98621a08326441e
Cr-Commit-Position: refs/heads/master@{#308995}

Powered by Google App Engine
This is Rietveld 408576698