Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: PRESUBMIT.py

Issue 805483002: Removed references to mac_gpu, which has been removed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | PRESUBMIT_test.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 1585 matching lines...) Expand 10 before | Expand all | Expand 10 after
1596 1596
1597 def GetTryServerMasterForBot(bot): 1597 def GetTryServerMasterForBot(bot):
1598 """Returns the Try Server master for the given bot. 1598 """Returns the Try Server master for the given bot.
1599 1599
1600 It tries to guess the master from the bot name, but may still fail 1600 It tries to guess the master from the bot name, but may still fail
1601 and return None. There is no longer a default master. 1601 and return None. There is no longer a default master.
1602 """ 1602 """
1603 # Potentially ambiguous bot names are listed explicitly. 1603 # Potentially ambiguous bot names are listed explicitly.
1604 master_map = { 1604 master_map = {
1605 'linux_gpu': 'tryserver.chromium.gpu', 1605 'linux_gpu': 'tryserver.chromium.gpu',
1606 'mac_gpu': 'tryserver.chromium.gpu',
1607 'win_gpu': 'tryserver.chromium.gpu', 1606 'win_gpu': 'tryserver.chromium.gpu',
1608 'chromium_presubmit': 'tryserver.chromium.linux', 1607 'chromium_presubmit': 'tryserver.chromium.linux',
1609 'blink_presubmit': 'tryserver.chromium.linux', 1608 'blink_presubmit': 'tryserver.chromium.linux',
1610 'tools_build_presubmit': 'tryserver.chromium.linux', 1609 'tools_build_presubmit': 'tryserver.chromium.linux',
1611 } 1610 }
1612 master = master_map.get(bot) 1611 master = master_map.get(bot)
1613 if not master: 1612 if not master:
1614 if 'gpu' in bot: 1613 if 'gpu' in bot:
1615 master = 'tryserver.chromium.gpu' 1614 master = 'tryserver.chromium.gpu'
1616 elif 'linux' in bot or 'android' in bot or 'presubmit' in bot: 1615 elif 'linux' in bot or 'android' in bot or 'presubmit' in bot:
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
1697 'linux_chromium_gn_dbg': ['compile'], 1696 'linux_chromium_gn_dbg': ['compile'],
1698 'linux_chromium_gn_rel': ['defaulttests'], 1697 'linux_chromium_gn_rel': ['defaulttests'],
1699 'linux_chromium_rel': ['defaulttests'], 1698 'linux_chromium_rel': ['defaulttests'],
1700 'linux_chromium_rel_ng': ['defaulttests'], 1699 'linux_chromium_rel_ng': ['defaulttests'],
1701 'linux_chromium_clang_dbg': ['defaulttests'], 1700 'linux_chromium_clang_dbg': ['defaulttests'],
1702 'linux_gpu': ['defaulttests'], 1701 'linux_gpu': ['defaulttests'],
1703 'linux_nacl_sdk_build': ['compile'], 1702 'linux_nacl_sdk_build': ['compile'],
1704 'mac_chromium_compile_dbg': ['defaulttests'], 1703 'mac_chromium_compile_dbg': ['defaulttests'],
1705 'mac_chromium_compile_dbg_ng': ['defaulttests'], 1704 'mac_chromium_compile_dbg_ng': ['defaulttests'],
1706 'mac_chromium_rel': ['defaulttests'], 1705 'mac_chromium_rel': ['defaulttests'],
1707 'mac_chromium_rel_ng': ['defaulttests'], 1706 'mac_chromium_rel_ng': ['defaulttests'],
Ken Russell (switch to Gerrit) 2014/12/12 18:47:47 Same question as for the CL removing linux_gpu and
Sergiy Byelozyorov 2014/12/15 16:00:23 I think 'defaulttests' is just a placeholder, whic
Paweł Hajdan Jr. 2014/12/15 16:01:36 Yeah, this is just a dummy value at this point. te
1708 'mac_gpu': ['defaulttests'],
1709 'mac_nacl_sdk_build': ['compile'], 1707 'mac_nacl_sdk_build': ['compile'],
1710 'win_chromium_compile_dbg': ['defaulttests'], 1708 'win_chromium_compile_dbg': ['defaulttests'],
1711 'win_chromium_dbg': ['defaulttests'], 1709 'win_chromium_dbg': ['defaulttests'],
1712 'win_chromium_rel': ['defaulttests'], 1710 'win_chromium_rel': ['defaulttests'],
1713 'win_chromium_rel_ng': ['defaulttests'], 1711 'win_chromium_rel_ng': ['defaulttests'],
1714 'win_chromium_x64_rel': ['defaulttests'], 1712 'win_chromium_x64_rel': ['defaulttests'],
1715 'win_chromium_x64_rel_ng': ['defaulttests'], 1713 'win_chromium_x64_rel_ng': ['defaulttests'],
1716 'win_gpu': ['defaulttests'], 1714 'win_gpu': ['defaulttests'],
1717 'win_nacl_sdk_build': ['compile'], 1715 'win_nacl_sdk_build': ['compile'],
1718 'win8_chromium_rel': ['defaulttests'], 1716 'win8_chromium_rel': ['defaulttests'],
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
1792 'linux_chromium_asan_rel', 1790 'linux_chromium_asan_rel',
1793 'linux_chromium_chromeos_compile_dbg_ng', 1791 'linux_chromium_chromeos_compile_dbg_ng',
1794 'linux_chromium_chromeos_rel_ng', 1792 'linux_chromium_chromeos_rel_ng',
1795 'linux_chromium_compile_dbg_32_ng', 1793 'linux_chromium_compile_dbg_32_ng',
1796 'linux_chromium_gn_dbg', 1794 'linux_chromium_gn_dbg',
1797 'linux_chromium_gn_rel', 1795 'linux_chromium_gn_rel',
1798 'linux_chromium_rel_ng', 1796 'linux_chromium_rel_ng',
1799 'linux_gpu', 1797 'linux_gpu',
1800 'mac_chromium_compile_dbg_ng', 1798 'mac_chromium_compile_dbg_ng',
1801 'mac_chromium_rel_ng', 1799 'mac_chromium_rel_ng',
1802 'mac_gpu',
1803 'win_chromium_compile_dbg', 1800 'win_chromium_compile_dbg',
1804 'win_chromium_rel', 1801 'win_chromium_rel',
1805 'win_chromium_x64_rel', 1802 'win_chromium_x64_rel',
1806 'win_gpu', 1803 'win_gpu',
1807 'win8_chromium_rel', 1804 'win8_chromium_rel',
1808 ] 1805 ]
1809 1806
1810 # Match things like path/aura/file.cc and path/file_aura.cc. 1807 # Match things like path/aura/file.cc and path/file_aura.cc.
1811 # Same for chromeos. 1808 # Same for chromeos.
1812 if any(re.search(r'[\\\/_](aura|chromeos)', f) for f in files): 1809 if any(re.search(r'[\\\/_](aura|chromeos)', f) for f in files):
1813 builders.extend([ 1810 builders.extend([
1814 'linux_chromeos_asan', 1811 'linux_chromeos_asan',
1815 ]) 1812 ])
1816 1813
1817 return GetDefaultTryConfigs(builders) 1814 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | PRESUBMIT_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698