Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 805453002: Introduced PropertyType ACCESSOR_FIELD. (Closed)

Created:
6 years ago by Igor Sheludko
Modified:
6 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Introduced PropertyType ACCESSOR_FIELD. Committed: https://crrev.com/08146dc023ea02608a4184f88c292bd8f299aed0 Cr-Commit-Position: refs/heads/master@{#25842}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -107 lines) Patch
M src/bootstrapper.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap-snapshot-generator.h View 2 chunks +8 lines, -2 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 3 chunks +44 lines, -45 lines 0 comments Download
M src/lookup-inl.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/objects.cc View 5 chunks +30 lines, -18 lines 0 comments Download
M src/objects-printer.cc View 2 chunks +14 lines, -13 lines 0 comments Download
M src/property.cc View 2 chunks +13 lines, -24 lines 0 comments Download
M src/property-details.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M test/cctest/test-transitions.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Igor Sheludko
PTAL
6 years ago (2014-12-15 17:28:23 UTC) #9
Jakob Kummerow
LGTM with a nit https://codereview.chromium.org/805453002/diff/180001/src/heap-snapshot-generator.cc File src/heap-snapshot-generator.cc (right): https://codereview.chromium.org/805453002/diff/180001/src/heap-snapshot-generator.cc#newcode1632 src/heap-snapshot-generator.cc:1632: Representation r = descs->GetDetails(i).representation(); nit: ...
6 years ago (2014-12-16 12:28:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805453002/200001
6 years ago (2014-12-16 12:48:26 UTC) #14
Igor Sheludko
https://codereview.chromium.org/805453002/diff/180001/src/heap-snapshot-generator.cc File src/heap-snapshot-generator.cc (right): https://codereview.chromium.org/805453002/diff/180001/src/heap-snapshot-generator.cc#newcode1632 src/heap-snapshot-generator.cc:1632: Representation r = descs->GetDetails(i).representation(); On 2014/12/16 12:28:43, Jakob wrote: ...
6 years ago (2014-12-16 12:49:15 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:200001)
6 years ago (2014-12-16 13:22:29 UTC) #16
commit-bot: I haz the power
6 years ago (2014-12-17 10:14:13 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/08146dc023ea02608a4184f88c292bd8f299aed0
Cr-Commit-Position: refs/heads/master@{#25842}

Powered by Google App Engine
This is Rietveld 408576698