Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: src/lookup-inl.h

Issue 805453002: Introduced PropertyType ACCESSOR_FIELD. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap-snapshot-generator.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_LOOKUP_INL_H_ 5 #ifndef V8_LOOKUP_INL_H_
6 #define V8_LOOKUP_INL_H_ 6 #define V8_LOOKUP_INL_H_
7 7
8 #include "src/lookup.h" 8 #include "src/lookup.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 PropertyCell* cell = PropertyCell::cast(dict->ValueAt(number_)); 56 PropertyCell* cell = PropertyCell::cast(dict->ValueAt(number_));
57 if (cell->value()->IsTheHole()) return NOT_FOUND; 57 if (cell->value()->IsTheHole()) return NOT_FOUND;
58 } 58 }
59 } else { 59 } else {
60 DescriptorArray* descriptors = map->instance_descriptors(); 60 DescriptorArray* descriptors = map->instance_descriptors();
61 number_ = descriptors->SearchWithCache(*name_, map); 61 number_ = descriptors->SearchWithCache(*name_, map);
62 if (number_ == DescriptorArray::kNotFound) return NOT_FOUND; 62 if (number_ == DescriptorArray::kNotFound) return NOT_FOUND;
63 property_details_ = descriptors->GetDetails(number_); 63 property_details_ = descriptors->GetDetails(number_);
64 } 64 }
65 has_property_ = true; 65 has_property_ = true;
66 switch (property_details_.type()) { 66 switch (property_details_.kind()) {
67 case v8::internal::CONSTANT: 67 case v8::internal::DATA:
68 case v8::internal::FIELD:
69 return DATA; 68 return DATA;
70 case v8::internal::CALLBACKS: 69 case v8::internal::ACCESSOR:
71 return ACCESSOR; 70 return ACCESSOR;
72 } 71 }
73 case ACCESSOR: 72 case ACCESSOR:
74 case DATA: 73 case DATA:
75 return NOT_FOUND; 74 return NOT_FOUND;
76 case JSPROXY: 75 case JSPROXY:
77 case TRANSITION: 76 case TRANSITION:
78 UNREACHABLE(); 77 UNREACHABLE();
79 } 78 }
80 UNREACHABLE(); 79 UNREACHABLE();
81 return state_; 80 return state_;
82 } 81 }
83 } 82 }
84 } // namespace v8::internal 83 } // namespace v8::internal
85 84
86 #endif // V8_LOOKUP_INL_H_ 85 #endif // V8_LOOKUP_INL_H_
OLDNEW
« no previous file with comments | « src/heap-snapshot-generator.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698