Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 805153005: Updating MakeMenuItemStringsFor() to test icon attribute of menuitems. (Closed)

Created:
5 years, 11 months ago by pals
Modified:
5 years, 11 months ago
Reviewers:
no sievers, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating MakeMenuItemStringsFor() to test icon attribute of menuitems. BUG=87553 Committed: https://crrev.com/2adb5c5ab67cd4da18b1d10fd40fce8337a4d24d Cr-Commit-Position: refs/heads/master@{#311259}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M content/public/common/menu_item.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/menu_item.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/menu_item_builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 30 (15 generated)
pals
This CL is needed to test https://codereview.chromium.org/802233004/. PTAL.
5 years, 11 months ago (2015-01-02 11:55:33 UTC) #2
no sievers
lgtm
5 years, 11 months ago (2015-01-05 20:11:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805153005/1
5 years, 11 months ago (2015-01-06 04:47:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/109906) android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/30129) android_chromium_gn_compile_rel ...
5 years, 11 months ago (2015-01-06 05:00:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805153005/1
5 years, 11 months ago (2015-01-08 05:03:45 UTC) #11
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-08 07:04:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805153005/1
5 years, 11 months ago (2015-01-08 08:04:55 UTC) #15
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-08 10:06:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805153005/1
5 years, 11 months ago (2015-01-09 13:15:22 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805153005/1
5 years, 11 months ago (2015-01-12 05:27:39 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805153005/1
5 years, 11 months ago (2015-01-12 10:04:32 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805153005/1
5 years, 11 months ago (2015-01-13 05:21:17 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805153005/20001
5 years, 11 months ago (2015-01-13 09:43:02 UTC) #28
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-13 11:27:21 UTC) #29
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 11:28:55 UTC) #30
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2adb5c5ab67cd4da18b1d10fd40fce8337a4d24d
Cr-Commit-Position: refs/heads/master@{#311259}

Powered by Google App Engine
This is Rietveld 408576698