Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1868)

Unified Diff: content/shell/renderer/test_runner/event_sender.cc

Issue 805153005: Updating MakeMenuItemStringsFor() to test icon attribute of menuitems. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/menu_item_builder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/renderer/test_runner/event_sender.cc
diff --git a/content/shell/renderer/test_runner/event_sender.cc b/content/shell/renderer/test_runner/event_sender.cc
index 09bfd68aedf1fd10ec7ec0f670adc25c045b511d..e976c626300e5560901c1ac69fa4b0da95c6ff8e 100644
--- a/content/shell/renderer/test_runner/event_sender.cc
+++ b/content/shell/renderer/test_runner/event_sender.cc
@@ -153,11 +153,12 @@ void PopulateCustomItems(const WebVector<WebMenuItemInfo>& customItems,
strings->push_back(prefixCopy + kSeparatorIdentifier);
} else if (customItems[i].type == blink::WebMenuItemInfo::SubMenu) {
strings->push_back(prefixCopy + customItems[i].label.utf8() +
- kSubMenuIdentifier);
+ customItems[i].icon.utf8() + kSubMenuIdentifier);
PopulateCustomItems(customItems[i].subMenuItems, prefixCopy +
kSubMenuDepthIdentifier, strings);
} else {
- strings->push_back(prefixCopy + customItems[i].label.utf8());
+ strings->push_back(prefixCopy + customItems[i].label.utf8() +
+ customItems[i].icon.utf8());
}
}
}
« no previous file with comments | « content/renderer/menu_item_builder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698