Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 805003002: [Ozone-Demo] Add support for NativeDisplayDelegate (Closed)

Created:
6 years ago by dnicoara
Modified:
5 years, 10 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ozone-demo2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone-Demo] Add support for NativeDisplayDelegate If a NativeDisplayDelegate is provided, then use it to configure the displays and show a DemoWindow on each display. BUG=none Committed: https://crrev.com/655c4e624ca9257fec92be97c2e6424b73c0c92d Cr-Commit-Position: refs/heads/master@{#315798}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Make sure to change context when rendering in a different surface #

Patch Set 4 : Make sure we support multiple screens #

Patch Set 5 : . #

Patch Set 6 : Update #

Patch Set 7 : Removed static #

Patch Set 8 : Keep our story straight and post tasks that are supposed to be proxied to the GPU #

Total comments: 6

Patch Set 9 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -62 lines) Patch
M ui/ozone/demo/gl_renderer.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/demo/ozone_demo.cc View 1 2 3 4 5 6 7 8 6 chunks +250 lines, -56 lines 0 comments Download
M ui/ozone/demo/surfaceless_gl_renderer.h View 1 2 3 4 5 6 3 chunks +8 lines, -3 lines 0 comments Download
M ui/ozone/demo/surfaceless_gl_renderer.cc View 1 2 3 4 5 6 4 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
dnicoara
PTAL
5 years, 11 months ago (2015-01-13 21:47:52 UTC) #2
dnicoara
Removed static declaration as per offline discussion.
5 years, 11 months ago (2015-01-14 15:07:01 UTC) #3
alexst (slow to review)
https://codereview.chromium.org/805003002/diff/140001/ui/ozone/demo/gl_renderer.cc File ui/ozone/demo/gl_renderer.cc (right): https://codereview.chromium.org/805003002/diff/140001/ui/ozone/demo/gl_renderer.cc#newcode47 ui/ozone/demo/gl_renderer.cc:47: context_->MakeCurrent(surface_.get()); Why do we need this on every render ...
5 years, 10 months ago (2015-02-11 15:36:05 UTC) #4
dnicoara
https://codereview.chromium.org/805003002/diff/140001/ui/ozone/demo/gl_renderer.cc File ui/ozone/demo/gl_renderer.cc (right): https://codereview.chromium.org/805003002/diff/140001/ui/ozone/demo/gl_renderer.cc#newcode47 ui/ozone/demo/gl_renderer.cc:47: context_->MakeCurrent(surface_.get()); On 2015/02/11 15:36:05, alexst wrote: > Why do ...
5 years, 10 months ago (2015-02-11 16:46:38 UTC) #5
alexst (slow to review)
lgtm
5 years, 10 months ago (2015-02-11 16:49:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805003002/160001
5 years, 10 months ago (2015-02-11 18:03:51 UTC) #8
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 10 months ago (2015-02-11 18:26:03 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 18:27:04 UTC) #10
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/655c4e624ca9257fec92be97c2e6424b73c0c92d
Cr-Commit-Position: refs/heads/master@{#315798}

Powered by Google App Engine
This is Rietveld 408576698