Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc

Issue 804993008: nacl_io: accept now allows addr and len to be NULL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bug number in commit message Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« AUTHORS ('K') | « native_client_sdk/src/libraries/nacl_io/socket/tcp_node.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc
diff --git a/native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc b/native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc
index ae125c3968ebe1c8e445dd9693ed24d355bc521a..4a5df4db06216985ff0a2d55b7110226b83bb052 100644
--- a/native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc
+++ b/native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc
@@ -608,6 +608,29 @@ TEST_F(SocketTestUDP, Sockopt_BUFSIZE) {
<< "failed with: " << strerror(errno);
}
+TEST_F(SocketTestTCP, AcceptNoParams) {
+ sockaddr_in addr;
+ socklen_t addrlen = sizeof(addr);
+ int server_sock = sock1_;
+
+ // Bind and Listen
+ ASSERT_EQ(0, Bind(server_sock, LOCAL_HOST, PORT1));
+ ASSERT_EQ(0, ki_listen(server_sock, 10));
Sam Clegg 2014/12/24 13:09:35 Remove extra space.
daiweili 2014/12/24 17:27:08 Done.
+
+ // Connect to listening socket, and send greeting
Sam Clegg 2014/12/24 13:09:35 Comment is inaccurate.
daiweili 2014/12/24 17:27:08 Done.
+ int client_sock = sock2_;
+ IP4ToSockAddr(LOCAL_HOST, PORT1, &addr);
+ addrlen = sizeof(addr);
+ ASSERT_EQ(0, ki_connect(client_sock, (sockaddr*)&addr, addrlen))
+ << "Failed with " << errno << ": " << strerror(errno);
+
+ // Accept without addr and len should succeed
+ int new_socket = ki_accept(server_sock, NULL, NULL);
+ ASSERT_GT(new_socket, -1);
+
+ ASSERT_EQ(0, ki_close(new_socket));
+}
+
TEST_F(SocketTestTCP, Listen) {
sockaddr_in addr;
socklen_t addrlen = sizeof(addr);
« AUTHORS ('K') | « native_client_sdk/src/libraries/nacl_io/socket/tcp_node.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698