Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 804993002: Internalize strings being stored into uninitialized property cells (Closed)

Created:
6 years ago by Jakob Kummerow
Modified:
6 years ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Internalize strings being stored into uninitialized property cells Committed: https://crrev.com/c060f4e26c6678c558df84492107a9ece984a585 Cr-Commit-Position: refs/heads/master@{#25822}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -17 lines) Patch
M src/lookup.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/lookup.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M src/objects.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/objects.cc View 5 chunks +15 lines, -6 lines 0 comments Download
M test/cctest/test-strings.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-1757.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-320922.js View 1 chunk +4 lines, -2 lines 0 comments Download
M test/mjsunit/string-slices.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Jakob Kummerow
PTAL. Some tests needed minor updates because they're testing builtins that don't expect to be ...
6 years ago (2014-12-15 14:50:32 UTC) #2
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/804993002/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/804993002/diff/1/src/objects.h#newcode9660 src/objects.h:9660: // will be deoptimized. Please ...
6 years ago (2014-12-15 15:11:49 UTC) #3
Jakob Kummerow
Thanks, landing. https://codereview.chromium.org/804993002/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/804993002/diff/1/src/objects.h#newcode9660 src/objects.h:9660: // will be deoptimized. On 2014/12/15 15:11:48, ...
6 years ago (2014-12-15 15:18:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804993002/20001
6 years ago (2014-12-15 15:19:25 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-15 15:46:07 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-17 10:13:32 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c060f4e26c6678c558df84492107a9ece984a585
Cr-Commit-Position: refs/heads/master@{#25822}

Powered by Google App Engine
This is Rietveld 408576698