Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: src/lookup.h

Issue 804993002: Internalize strings being stored into uninitialized property cells (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressed comment Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/lookup.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_LOOKUP_H_ 5 #ifndef V8_LOOKUP_H_
6 #define V8_LOOKUP_H_ 6 #define V8_LOOKUP_H_
7 7
8 #include "src/factory.h" 8 #include "src/factory.h"
9 #include "src/isolate.h" 9 #include "src/isolate.h"
10 #include "src/objects.h" 10 #include "src/objects.h"
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 bool IsReadOnly() const { return property_details().IsReadOnly(); } 129 bool IsReadOnly() const { return property_details().IsReadOnly(); }
130 Representation representation() const { 130 Representation representation() const {
131 return property_details().representation(); 131 return property_details().representation();
132 } 132 }
133 FieldIndex GetFieldIndex() const; 133 FieldIndex GetFieldIndex() const;
134 Handle<HeapType> GetFieldType() const; 134 Handle<HeapType> GetFieldType() const;
135 int GetConstantIndex() const; 135 int GetConstantIndex() const;
136 Handle<PropertyCell> GetPropertyCell() const; 136 Handle<PropertyCell> GetPropertyCell() const;
137 Handle<Object> GetAccessors() const; 137 Handle<Object> GetAccessors() const;
138 Handle<Object> GetDataValue() const; 138 Handle<Object> GetDataValue() const;
139 void WriteDataValue(Handle<Object> value); 139 // Usually returns the value that was passed in, but may perform
140 // non-observable modifications on it, such as internalize strings.
141 Handle<Object> WriteDataValue(Handle<Object> value);
140 142
141 // Checks whether the receiver is an indexed exotic object 143 // Checks whether the receiver is an indexed exotic object
142 // and name is a special numeric index. 144 // and name is a special numeric index.
143 bool IsSpecialNumericIndex() const; 145 bool IsSpecialNumericIndex() const;
144 146
145 void InternalizeName(); 147 void InternalizeName();
146 148
147 private: 149 private:
148 Handle<Map> GetReceiverMap() const; 150 Handle<Map> GetReceiverMap() const;
149 151
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 Handle<Object> receiver_; 196 Handle<Object> receiver_;
195 Handle<JSReceiver> holder_; 197 Handle<JSReceiver> holder_;
196 198
197 int number_; 199 int number_;
198 }; 200 };
199 201
200 202
201 } } // namespace v8::internal 203 } } // namespace v8::internal
202 204
203 #endif // V8_LOOKUP_H_ 205 #endif // V8_LOOKUP_H_
OLDNEW
« no previous file with comments | « no previous file | src/lookup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698