Highlight newly installed bookmark apps on non-ash desktops.

Highlight newly installed bookmark apps on non-ash desktops.

Otherwise it appears like nothing happened when a bookmark app is
created. This change does not affect bookmark apps created via sync.

BUG=441617
Committed: https://crrev.com/424d9a3414180110b6941c40b5ab6b4323ebd8cf
Cr-Commit-Position: refs/heads/master@{#308470}

[benwells, 2014-12-15 02:58:20]

benwells@chromium.org changed reviewers:
+ calamity@chromium.org

[calamity, 2014-12-15 03:38:09]

https://codereview.chromium.org/804883002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc (right):

https://codereview.chromium.org/804883002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc:286:
&install_info);
Hmm. Doesn't this happen asynchronously? I guess it's ok since the extension
already has to exist so all the showing code below will work..

Consider adding a comment about this though.

https://codereview.chromium.org/804883002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc:296: Profile*
current_profile = profile_->GetOriginalProfile();
Is this for dealing with incognito profiles? Should incognito profiles ever be
able to get here?

[benwells, 2014-12-15 05:01:30]

Patchset #3 (id:40001) has been deleted

[benwells, 2014-12-15 05:02:47]

https://codereview.chromium.org/804883002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc (right):

https://codereview.chromium.org/804883002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc:286:
&install_info);
On 2014/12/15 03:38:09, calamity wrote:
> Hmm. Doesn't this happen asynchronously? I guess it's ok since the extension
> already has to exist so all the showing code below will work..
> 
> Consider adding a comment about this though.

Good point. It was unsafe before, I've made it safe now (by only using the ID)
and added a comment.

https://codereview.chromium.org/804883002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc:296: Profile*
current_profile = profile_->GetOriginalProfile();
On 2014/12/15 03:38:09, calamity wrote:
> Is this for dealing with incognito profiles? Should incognito profiles ever be
> able to get here?

You can add bookmark apps in incognito, but they appear in the original profile.
This code deals with that.

[calamity, 2014-12-15 05:05:55]

lgtm

[benwells, 2014-12-15 05:11:01]

benwells@chromium.org changed reviewers:
+ finnur@chromium.org

[benwells, 2014-12-15 05:11:02]

+finnur for owners review.

[Finnur, 2014-12-15 14:11:20]

OWNERS LGTM.

[Finnur, 2014-12-15 14:11:29]

With one nit.

https://codereview.chromium.org/804883002/diff/60001/chrome/browser/ui/views/...
File chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc (right):

https://codereview.chromium.org/804883002/diff/60001/chrome/browser/ui/views/...
chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc:287: // used
later on to highlight the app.
nit: Should we explicitly set the pointer to NULL to prevent accidental use?

[benwells, 2014-12-15 22:55:21]

On 2014/12/15 14:11:29, Finnur wrote:
> With one nit.
> 
>
https://codereview.chromium.org/804883002/diff/60001/chrome/browser/ui/views/...
> File chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc (right):
> 
>
https://codereview.chromium.org/804883002/diff/60001/chrome/browser/ui/views/...
> chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc:287: // used
> later on to highlight the app.
> nit: Should we explicitly set the pointer to NULL to prevent accidental use?

Done.

[benwells, 2014-12-15 23:03:28]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2014-12-15 23:05:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/804883002/80001

[commit-bot: I haz the power, 2014-12-16 00:15:34]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2014-12-16 00:16:31]

Patchset 4 (id:??) landed as
https://crrev.com/424d9a3414180110b6941c40b5ab6b4323ebd8cf
Cr-Commit-Position: refs/heads/master@{#308470}