Highlight newly installed bookmark apps on non-ash desktops.

chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h"
 
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/app_icon_loader_impl.h"
 #include "chrome/browser/extensions/bookmark_app_helper.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/launch_util.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/app_list/app_list_service.h"
+#include "chrome/browser/ui/app_list/app_list_util.h"
+#include "chrome/browser/ui/browser_navigator.h"
+#include "chrome/browser/ui/host_desktop.h"
 #include "chrome/common/extensions/extension_constants.h"
+#include "chrome/common/url_constants.h"
 #include "chrome/grit/generated_resources.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/browser/web_contents.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/pref_names.h"
 #include "extensions/browser/uninstall_reason.h"
 #include "extensions/common/constants.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/events/keycodes/keyboard_codes.h"
 #include "ui/views/controls/button/checkbox.h"
@@ skipping 232 matching lines @@
       : extensions::LAUNCH_TYPE_WINDOW;
   profile_->GetPrefs()->SetInteger(
           extensions::pref_names::kBookmarkAppCreationLaunchType, launch_type);
   extensions::SetLaunchType(GetExtensionService(profile_),
                             extension_id_,
                             launch_type);
 
   const extensions::Extension* extension =
       extensions::ExtensionRegistry::Get(profile_)->GetExtensionById(
           extension_id_, extensions::ExtensionRegistry::EVERYTHING);
-  if (extension && base::UTF8ToUTF16(extension->name()) == title_tf_->text())
+
+  if (!extension)
     return;
 
-  // Reinstall the app with an updated name.
-  WebApplicationInfo install_info(web_app_info_);
-  install_info.title = title_tf_->text();
+  if (base::UTF8ToUTF16(extension->name()) != title_tf_->text()) {
+    // Reinstall the app with an updated name.
+    WebApplicationInfo install_info(web_app_info_);
+    install_info.title = title_tf_->text();
 
-  extensions::CreateOrUpdateBookmarkApp(GetExtensionService(profile_),
-                                        &install_info);
+    extensions::CreateOrUpdateBookmarkApp(GetExtensionService(profile_),
+                                          &install_info);

[calamity, 2014/12/15 03:38:09]

Hmm. Doesn't this happen asynchronously? I guess it's ok since the extension
already has to exist so all the showing code below will work..

Consider adding a comment about this though.

[benwells, 2014/12/15 05:02:47]

Good point. It was unsafe before, I've made it safe now (by only using the ID)
and added a comment.

+  }
+
+  // Show the newly installed app in the app launcher or chrome://apps. Don't
+  // do this on ash, as the icon will have been added to the shelf.
+  chrome::HostDesktopType desktop =
+      chrome::GetHostDesktopTypeForNativeWindow(GetWidget()->GetNativeWindow());
+  if (desktop == chrome::HOST_DESKTOP_TYPE_ASH)
+    return;
+
+  Profile* current_profile = profile_->GetOriginalProfile();

[calamity, 2014/12/15 03:38:09]

Is this for dealing with incognito profiles? Should incognito profiles ever be
able to get here?

[benwells, 2014/12/15 05:02:47]

You can add bookmark apps in incognito, but they appear in the original profile.
This code deals with that.

+  if (IsAppLauncherEnabled()) {
+    AppListService::Get(desktop)
+        ->ShowForAppInstall(current_profile, extension->id(), false);
+    return;
+  }
+
+  std::string app_id = extension->id();
+  chrome::NavigateParams params(current_profile,
+                                GURL(chrome::kChromeUIAppsURL),
+                                ui::PAGE_TRANSITION_LINK);
+  params.disposition = NEW_FOREGROUND_TAB;
+  chrome::Navigate(&params);
+
+  content::NotificationService::current()->Notify(
+      chrome::NOTIFICATION_APP_INSTALLED_TO_NTP,
+      content::Source<content::WebContents>(params.target_contents),
+      content::Details<const std::string>(&app_id));
 }