Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 804873003: Clear matched properties cache for theme color changes. (Closed)

Created:
6 years ago by rune
Modified:
6 years ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-rendering, dglazkov+blink, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Clear matched properties cache for theme color changes. A theme dependent color is represented by a keyword in CSS and the matched property value won't change when the theme color changes. That lead to a cache hit in MatchPropertiesCache so that a style recalc after changing the theme wouldn't have an effect. So, we need to invalidate the cache on such changes. Changed method name and api layering to contain knowledge about necessary changes in the StyleEngine. BUG=441144 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187517

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -4 lines) Patch
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Document.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/dom/StyleEngine.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/StyleEngine.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/page/Page.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 chunk +1 line, -1 line 0 comments Download
A Source/core/rendering/RenderThemeTest.cpp View 1 chunk +92 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rune
6 years ago (2014-12-18 10:59:40 UTC) #2
Timothy Loh
On 2014/12/18 10:59:40, rune wrote: lgtm
6 years ago (2014-12-18 22:52:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804873003/1
6 years ago (2014-12-18 22:57:18 UTC) #5
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
6 years ago (2014-12-19 02:07:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804873003/1
6 years ago (2014-12-19 07:02:10 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-19 08:37:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187517

Powered by Google App Engine
This is Rietveld 408576698