Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: ui/app_list/PRESUBMIT.py

Issue 804763002: ui/app_list: Enable a set of cpplint checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/PRESUBMIT.py
diff --git a/ui/app_list/PRESUBMIT.py b/ui/app_list/PRESUBMIT.py
index 0582ac4a071c5e3d38610d008994ffe6a3f05c08..dd70e92ae9c760ff0222493e7e012503247aa757 100644
--- a/ui/app_list/PRESUBMIT.py
+++ b/ui/app_list/PRESUBMIT.py
@@ -23,7 +23,7 @@ def CheckChangeLintsClean(input_api, output_api):
sources = lambda x: input_api.FilterSourceFile(
x, white_list = INCLUDE_CPP_FILES_ONLY, black_list = black_list)
return input_api.canned_checks.CheckChangeLintsClean(
- input_api, output_api, sources)
+ input_api, output_api, sources, '')
tfarina 2014/12/14 03:35:59 Is this correct? Hopefully, this will help us to
tapted 2014/12/15 22:12:55 nah - it should be [] i.e. return input_api.ca
tfarina 2014/12/15 23:45:19 Thanks for being patience with me in these review
def CheckChangeOnUpload(input_api, output_api):
results = []
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698