ui/app_list: Enable a set of cpplint checks.

ui/app_list/PRESUBMIT.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Presubmit script for app_list.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into depot_tools.
 """
 
 INCLUDE_CPP_FILES_ONLY = (
   r'.*\.(cc|h)$',
 )
 
 EXCLUDE = (
   # Objective C confuses everything.
   r'.*/cocoa/.*',
 )
 
 def CheckChangeLintsClean(input_api, output_api):
   """Makes sure that the ui/app_list/ code is cpplint clean."""
   black_list = input_api.DEFAULT_BLACK_LIST + EXCLUDE
   sources = lambda x: input_api.FilterSourceFile(
     x, white_list = INCLUDE_CPP_FILES_ONLY, black_list = black_list)
   return input_api.canned_checks.CheckChangeLintsClean(
-      input_api, output_api, sources)
+      input_api, output_api, sources, '')

[tfarina, 2014/12/14 03:35:59]

Is this correct?

Hopefully, this will help us to catch everything (that were always regressing)
again.

[tapted, 2014/12/15 22:12:55]

nah - it should be []

i.e.

  return input_api.canned_checks.CheckChangeLintsClean(
      input_api, output_api, sources, [])


lgtm after that

[tfarina, 2014/12/15 23:45:19]

Thanks for being  patience with me in these reviews. You see I'm weak on Python.
Weird language, the lack of type is so annoying and forces you to guess types
(so for me, that is not familiar with the language, causes this), much like
JavaScript. 

Done.

 
 def CheckChangeOnUpload(input_api, output_api):
   results = []
   results += CheckChangeLintsClean(input_api, output_api)
   results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)
   return results