Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: media/cdm/ppapi/cdm_adapter.cc

Issue 804713003: Relax DCHECK for |legacy_destination_url| (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cdm/ppapi/cdm_adapter.cc
diff --git a/media/cdm/ppapi/cdm_adapter.cc b/media/cdm/ppapi/cdm_adapter.cc
index 00a2fe3958a0225b56d744494adbb8a26eda380b..c0a39a56d2faa7610cb612e92f1bd12e3bdb1ffc 100644
--- a/media/cdm/ppapi/cdm_adapter.cc
+++ b/media/cdm/ppapi/cdm_adapter.cc
@@ -718,11 +718,11 @@ void CdmAdapter::OnSessionMessage(const char* session_id,
uint32_t message_size,
const char* legacy_destination_url,
uint32_t legacy_destination_url_size) {
- // Only license renewals should specify |legacy_destination_url|.
+ // License requests should not specify |legacy_destination_url|.
// |legacy_destination_url| is not passed to unprefixed EME applications,
// so it can be removed when the prefixed API is removed.
PP_DCHECK(legacy_destination_url_size == 0 ||
- message_type == cdm::MessageType::kLicenseRenewal);
+ message_type != cdm::MessageType::kLicenseRequest);
ddorwin 2015/01/14 21:11:52 The inverted logic won't automatically catch new t
jrummell 2015/01/14 21:42:37 Acknowledged.
PostOnMain(callback_factory_.NewCallback(
&CdmAdapter::SendSessionMessageInternal,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698