Relax DCHECK for |legacy_destination_url|

media/cdm/ppapi/cdm_adapter.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cdm/ppapi/cdm_adapter.h"
 
 #include "media/base/limits.h"
 #include "media/cdm/ppapi/cdm_file_io_impl.h"
 #include "media/cdm/ppapi/cdm_helpers.h"
 #include "media/cdm/ppapi/cdm_logging.h"
@@ skipping 700 matching lines @@
 }
 
 // cdm::Host_7 only.
 void CdmAdapter::OnSessionMessage(const char* session_id,
                                   uint32_t session_id_size,
                                   cdm::MessageType message_type,
                                   const char* message,
                                   uint32_t message_size,
                                   const char* legacy_destination_url,
                                   uint32_t legacy_destination_url_size) {
-  // Only license renewals should specify |legacy_destination_url|.
+  // License requests should not specify |legacy_destination_url|.
   // |legacy_destination_url| is not passed to unprefixed EME applications,
   // so it can be removed when the prefixed API is removed.
   PP_DCHECK(legacy_destination_url_size == 0 ||
-            message_type == cdm::MessageType::kLicenseRenewal);
+            message_type != cdm::MessageType::kLicenseRequest);

[ddorwin, 2015/01/14 21:11:52]

The inverted logic won't automatically catch new types. However, this is
probably consistent with how the CDM is implemented, so it's fine. (Plus, this
parameter will be removed sometime this year.)

[jrummell, 2015/01/14 21:42:37]

Acknowledged.

 
   PostOnMain(callback_factory_.NewCallback(
       &CdmAdapter::SendSessionMessageInternal,
       SessionMessage(
           std::string(session_id, session_id_size), message_type, message,
           message_size,
           std::string(legacy_destination_url, legacy_destination_url_size))));
 }
 
 // cdm::Host_6 only.
@@ skipping 652 matching lines @@
 }  // namespace media
 
 namespace pp {
 
 // Factory function for your specialization of the Module object.
 Module* CreateModule() {
   return new media::CdmAdapterModule();
 }
 
 }  // namespace pp