Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 804713003: Relax DCHECK for |legacy_destination_url| (Closed)

Created:
5 years, 11 months ago by jrummell
Modified:
5 years, 11 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, eme-reviews_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Relax DCHECK for |legacy_destination_url| Only license requests should not specify |legacy_destination_url|. BUG=448242 Committed: https://crrev.com/77f5922a4dabfd5682d25619e80e5104426b4192 Cr-Commit-Position: refs/heads/master@{#311550}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/cdm/ppapi/cdm_adapter.cc View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
jrummell
PTAL.
5 years, 11 months ago (2015-01-14 20:38:06 UTC) #2
ddorwin
lgtm https://codereview.chromium.org/804713003/diff/1/media/cdm/ppapi/cdm_adapter.cc File media/cdm/ppapi/cdm_adapter.cc (right): https://codereview.chromium.org/804713003/diff/1/media/cdm/ppapi/cdm_adapter.cc#newcode725 media/cdm/ppapi/cdm_adapter.cc:725: message_type != cdm::MessageType::kLicenseRequest); The inverted logic won't automatically ...
5 years, 11 months ago (2015-01-14 21:11:52 UTC) #3
jrummell
Thanks for the review. https://codereview.chromium.org/804713003/diff/1/media/cdm/ppapi/cdm_adapter.cc File media/cdm/ppapi/cdm_adapter.cc (right): https://codereview.chromium.org/804713003/diff/1/media/cdm/ppapi/cdm_adapter.cc#newcode725 media/cdm/ppapi/cdm_adapter.cc:725: message_type != cdm::MessageType::kLicenseRequest); On 2015/01/14 ...
5 years, 11 months ago (2015-01-14 21:42:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804713003/1
5 years, 11 months ago (2015-01-14 21:43:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 22:03:17 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 22:04:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77f5922a4dabfd5682d25619e80e5104426b4192
Cr-Commit-Position: refs/heads/master@{#311550}

Powered by Google App Engine
This is Rietveld 408576698