Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 80463004: GN generator for GYP actions (Closed)

Created:
7 years, 1 month ago by brettw
Modified:
7 years, 1 month ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

This writes a generator for GYP actions to run Ninja for script targets. This does not yet include the code that actually writes the corresponding ninja files. The GYP code also needed some output directory generation code, so this was consolidated in filesystem_utils and referenced from the existing place. BUG=322244 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236837

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+514 lines, -138 lines) Patch
M tools/gn/BUILD.gn View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M tools/gn/file_template.h View 2 chunks +5 lines, -0 lines 0 comments Download
M tools/gn/file_template.cc View 1 2 3 4 5 2 chunks +11 lines, -0 lines 0 comments Download
M tools/gn/filesystem_utils.h View 1 2 3 4 5 1 chunk +21 lines, -0 lines 0 comments Download
M tools/gn/filesystem_utils.cc View 1 2 chunks +85 lines, -0 lines 0 comments Download
M tools/gn/filesystem_utils_unittest.cc View 1 1 chunk +82 lines, -0 lines 0 comments Download
M tools/gn/functions_target.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/gn.gyp View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M tools/gn/gyp_binary_target_writer.h View 3 chunks +10 lines, -4 lines 0 comments Download
M tools/gn/gyp_binary_target_writer.cc View 10 chunks +31 lines, -52 lines 0 comments Download
A tools/gn/gyp_script_target_writer.h View 1 2 3 4 5 6 1 chunk +29 lines, -0 lines 0 comments Download
A tools/gn/gyp_script_target_writer.cc View 1 2 1 chunk +108 lines, -0 lines 0 comments Download
A tools/gn/gyp_script_target_writer_unittest.cc View 1 2 3 4 5 6 1 chunk +57 lines, -0 lines 0 comments Download
M tools/gn/gyp_target_writer.h View 3 chunks +12 lines, -1 line 0 comments Download
M tools/gn/gyp_target_writer.cc View 1 2 3 4 5 3 chunks +28 lines, -4 lines 0 comments Download
M tools/gn/ninja_target_writer.h View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M tools/gn/scope_per_file_provider.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M tools/gn/scope_per_file_provider.cc View 1 5 chunks +6 lines, -62 lines 0 comments Download
M tools/gn/source_dir.h View 2 chunks +6 lines, -1 line 0 comments Download
M tools/gn/source_dir.cc View 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
7 years, 1 month ago (2013-11-21 23:06:37 UTC) #1
scottmg
nice, lgtm.
7 years, 1 month ago (2013-11-21 23:49:30 UTC) #2
brettw
7 years, 1 month ago (2013-11-22 22:10:30 UTC) #3
Message was sent while issue was closed. 
Committed patchset #7 manually as r236837 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698