Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/gn/gyp_binary_target_writer.h

Issue 80463004: GN generator for GYP actions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/gn.gyp ('k') | tools/gn/gyp_binary_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/gyp_binary_target_writer.h
diff --git a/tools/gn/gyp_binary_target_writer.h b/tools/gn/gyp_binary_target_writer.h
index 6fee4ad4fd9100d03fb1870b949295e7a255331b..8b3660ecd62a61d06010f036763e217f7109670c 100644
--- a/tools/gn/gyp_binary_target_writer.h
+++ b/tools/gn/gyp_binary_target_writer.h
@@ -17,7 +17,9 @@
// shared library, or a static library).
class GypBinaryTargetWriter : public GypTargetWriter {
public:
- GypBinaryTargetWriter(const TargetGroup& group, std::ostream& out);
+ GypBinaryTargetWriter(const TargetGroup& group,
+ const SourceDir& gyp_dir,
+ std::ostream& out);
virtual ~GypBinaryTargetWriter();
virtual void Run() OVERRIDE;
@@ -40,9 +42,6 @@ class GypBinaryTargetWriter : public GypTargetWriter {
std::vector<std::string> libs;
};
- // Writes the given number of spaces to the output stream and returns it.
- std::ostream& Indent(int spaces);
-
void WriteName(int indent);
void WriteType(int indent);
@@ -78,6 +77,13 @@ class GypBinaryTargetWriter : public GypTargetWriter {
Flags FlagsFromTarget(const Target* target) const;
Flags FlagsFromConfigList(const LabelConfigVector& configs) const;
+ // Writes the given array with the given name. The indent should be the
+ // indenting for the name, the values will be indented 2 spaces from there.
+ // Writes nothing if there is nothing in the array.
+ void WriteNamedArray(const char* name,
+ const std::vector<std::string>& values,
+ int indent);
+
// All associated targets.
TargetGroup group_;
« no previous file with comments | « tools/gn/gn.gyp ('k') | tools/gn/gyp_binary_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698