Issue 804593002: Move string16 and char16 in to base::

Issue 804593002: Move string16 and char16 in to base:: (Closed)

Created:
6 years ago by scottmg

Modified:
6 years ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Move string16 and char16 in to base:: Needs to include roll with https://codereview.chromium.org/803593002/ included. R=mark@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/af07f4022bf84880c6c4916676d20d77b2cd8f4a

Patch Set 3 : include roll of mini_chromium to 37bac7... #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -65 lines)			Patch
M	DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	compat/non_win/dbghelp.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	compat/non_win/timezoneapi.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	minidump/minidump_misc_info_writer_test.cc	View		11 chunks	+26 lines, -20 lines	0 comments	Download
M	minidump/minidump_module_writer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	minidump/minidump_module_writer_test.cc	View		2 chunks	+6 lines, -5 lines	0 comments	Download
M	minidump/minidump_string_writer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	minidump/minidump_string_writer_test.cc	View		4 chunks	+10 lines, -8 lines	0 comments	Download
M	minidump/minidump_writer_util.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	minidump/minidump_writer_util.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	minidump/test/minidump_string_writer_test_util.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	minidump/test/minidump_string_writer_test_util.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	minidump/test/minidump_writable_test_util.cc	View		1 chunk	+7 lines, -5 lines	0 comments	Download
M	util/stdlib/strlcpy.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	util/stdlib/strlcpy.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	util/stdlib/strlcpy_test.cc	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM https://codereview.chromium.org/804593002/diff/1/minidump/test/minidump_string_writer_test_util.cc File minidump/test/minidump_string_writer_test_util.cc (right): https://codereview.chromium.org/804593002/diff/1/minidump/test/minidump_string_writer_test_util.cc#newcode93 minidump/test/minidump_string_writer_test_util.cc:93: RVA rva) { Align this.

6 years ago (2014-12-12 19:02:11 UTC) #2

scottmg

https://codereview.chromium.org/804593002/diff/1/minidump/test/minidump_string_writer_test_util.cc File minidump/test/minidump_string_writer_test_util.cc (right): https://codereview.chromium.org/804593002/diff/1/minidump/test/minidump_string_writer_test_util.cc#newcode93 minidump/test/minidump_string_writer_test_util.cc:93: RVA rva) { On 2014/12/12 19:02:10, Mark Mentovai wrote: ...

6 years ago (2014-12-12 19:02:54 UTC) #3

scottmg

Committed patchset #3 (id:40001) manually as af07f4022bf84880c6c4916676d20d77b2cd8f4a (presubmit successful).

6 years ago (2014-12-12 19:06:13 UTC) #5

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages