Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: minidump/minidump_writer_util.cc

Issue 804593002: Move string16 and char16 in to base:: (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: include roll of mini_chromium to 37bac7... Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_writer_util.h ('k') | minidump/test/minidump_string_writer_test_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 14 matching lines...) Expand all
25 // static 25 // static
26 void MinidumpWriterUtil::AssignTimeT(uint32_t* destination, time_t source) { 26 void MinidumpWriterUtil::AssignTimeT(uint32_t* destination, time_t source) {
27 if (!base::IsValueInRangeForNumericType<uint32_t>(source)) { 27 if (!base::IsValueInRangeForNumericType<uint32_t>(source)) {
28 LOG(WARNING) << "timestamp " << source << " out of range"; 28 LOG(WARNING) << "timestamp " << source << " out of range";
29 } 29 }
30 30
31 *destination = source; 31 *destination = source;
32 } 32 }
33 33
34 // static 34 // static
35 string16 MinidumpWriterUtil::ConvertUTF8ToUTF16(const std::string& utf8) { 35 base::string16 MinidumpWriterUtil::ConvertUTF8ToUTF16(const std::string& utf8) {
36 string16 utf16; 36 base::string16 utf16;
37 if (!base::UTF8ToUTF16(utf8.data(), utf8.length(), &utf16)) { 37 if (!base::UTF8ToUTF16(utf8.data(), utf8.length(), &utf16)) {
38 LOG(WARNING) << "string " << utf8 38 LOG(WARNING) << "string " << utf8
39 << " cannot be converted to UTF-16 losslessly"; 39 << " cannot be converted to UTF-16 losslessly";
40 } 40 }
41 return utf16; 41 return utf16;
42 } 42 }
43 43
44 // static 44 // static
45 void MinidumpWriterUtil::AssignUTF8ToUTF16(char16* destination, 45 void MinidumpWriterUtil::AssignUTF8ToUTF16(base::char16* destination,
46 size_t destination_size, 46 size_t destination_size,
47 const std::string& source) { 47 const std::string& source) {
48 string16 source_utf16 = ConvertUTF8ToUTF16(source); 48 base::string16 source_utf16 = ConvertUTF8ToUTF16(source);
49 if (source_utf16.size() > destination_size - 1) { 49 if (source_utf16.size() > destination_size - 1) {
50 LOG(WARNING) << "string " << source << " UTF-16 length " 50 LOG(WARNING) << "string " << source << " UTF-16 length "
51 << source_utf16.size() 51 << source_utf16.size()
52 << " will be truncated to UTF-16 length " 52 << " will be truncated to UTF-16 length "
53 << destination_size - 1; 53 << destination_size - 1;
54 } 54 }
55 55
56 source_utf16.resize(destination_size - 1); 56 source_utf16.resize(destination_size - 1);
57 c16lcpy(destination, source_utf16.c_str(), destination_size); 57 c16lcpy(destination, source_utf16.c_str(), destination_size);
58 } 58 }
59 59
60 } // namespace internal 60 } // namespace internal
61 } // namespace crashpad 61 } // namespace crashpad
OLDNEW
« no previous file with comments | « minidump/minidump_writer_util.h ('k') | minidump/test/minidump_string_writer_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698