Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 804413002: Revert of Revert of telemetry: Clean up SurfaceFlinger statistics (Closed)

Created:
6 years ago by bokan
Modified:
6 years ago
CC:
chromium-reviews, klundberg+watch_chromium.org, telemetry+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, aelias_OOO_until_Jul13, klobag.chromium, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of telemetry: Clean up SurfaceFlinger statistics (patchset #1 id:1 of https://codereview.chromium.org/809753002/) Reason for revert: Relanding, this patch was not the culprit. Sorry. Original issue's description: > Revert of telemetry: Clean up SurfaceFlinger statistics (patchset #8 id:140001 of https://codereview.chromium.org/765773004/) > > Reason for revert: > Perf sheriff here, speculatively reverting due to crbug.com/442752, it shows up in many blamelists (but not all as the test wasn't running due to another bug). Sorry if unrelated. > > Original issue's description: > > PERF-SHERIFFS: This patch will change all smoothness and SurfaceFlinger metrics on Android. Some metrics may go up or down significantly, with the new values being more accurate. > > > > This patch cleans up the integration of SurfaceFlinger statistics by pulling the > > raw timestamps into the timeline and calculating all metrics in > > SmoothnessMetric. This approach also improves the metrics, because the > > timeline ranges can now be properly bounded (no more percentiles!) and the > > existing smoothness metrics can also use the more accurate SurfaceFlinger > > timestamps. > > > > BUG=351916 > > > > Committed: https://crrev.com/ebae600f54ed1e77eeba916635310fb176c0fb6c > > Cr-Commit-Position: refs/heads/master@{#308488} > > TBR=tonyg@chromium.org,dtu@chromium.org,nednguyen@google.com,chrishenry@google.com,skyostil@google.com,sullivan@chromium.org,skyostil@chromium.org,jbudorick@chromium.org,ernstm@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=351916 > > Committed: https://crrev.com/3dfc4e90757197efe0855fd4889d32bc52cb4cf9 > Cr-Commit-Position: refs/heads/master@{#308594} TBR=tonyg@chromium.org,dtu@chromium.org,nednguyen@google.com,chrishenry@google.com,skyostil@google.com,sullivan@chromium.org,skyostil@chromium.org,jbudorick@chromium.org,ernstm@chromium.org NOTREECHECKS=true NOTRY=true BUG=351916 Committed: https://crrev.com/e2f820e34c43102785cfc9f38bde8b5a052938b8 Cr-Commit-Position: refs/heads/master@{#308608}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -439 lines) Patch
M build/android/pylib/perf/surface_stats_collector.py View 7 chunks +17 lines, -138 lines 0 comments Download
D build/android/surface_stats.py View 1 chunk +0 lines, -142 lines 0 comments Download
M tools/perf/measurements/smoothness_controller.py View 4 chunks +13 lines, -31 lines 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/__init__.py View 1 chunk +17 lines, -33 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 3 chunks +10 lines, -16 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/cros_platform_backend.py View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/ios_platform_backend.py View 2 chunks +0 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/linux_platform_backend.py View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/linux_platform_backend_unittest.py View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/mac_platform_backend.py View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/platform_backend.py View 1 chunk +7 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/win_platform_backend.py View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/timeline/model.py View 4 chunks +14 lines, -1 line 0 comments Download
A tools/telemetry/telemetry/timeline/surface_flinger_importer.py View 1 chunk +39 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/timeline/surface_flinger_timeline_data.py View 1 chunk +29 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/rendering_stats.py View 3 chunks +17 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py View 6 chunks +77 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/smoothness.py View 3 chunks +73 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py View 3 chunks +33 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bokan
Created Revert of Revert of telemetry: Clean up SurfaceFlinger statistics
6 years ago (2014-12-16 17:49:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804413002/1
6 years ago (2014-12-16 17:49:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-16 17:50:59 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-16 17:51:47 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2f820e34c43102785cfc9f38bde8b5a052938b8
Cr-Commit-Position: refs/heads/master@{#308608}

Powered by Google App Engine
This is Rietveld 408576698