Revert of Revert of telemetry: Clean up SurfaceFlinger statistics

tools/perf/measurements/smoothness_controller.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import sys
 
 from measurements import smooth_gesture_util
 from telemetry.core.platform import tracing_category_filter
 from telemetry.core.platform import tracing_options
 from telemetry.timeline.model import TimelineModel
 from telemetry.page import page_test
 from telemetry.page.actions import action_runner
 from telemetry.value import list_of_scalar_values
 from telemetry.value import scalar
 from telemetry.value import trace
 from telemetry.web_perf import timeline_interaction_record as tir_module
 from telemetry.web_perf.metrics import smoothness
 
 
 RUN_SMOOTH_ACTIONS = 'RunSmoothAllActions'
 
-# Descriptions for results from platform.GetRawDisplayFrameRateMeasurements().
-DESCRIPTIONS = {
-    'avg_surface_fps': 'Average frames per second as measured by the '
-                       'platform\'s SurfaceFlinger.'
-}
-
-
-class MissingDisplayFrameRateError(page_test.MeasurementFailure):
-  def __init__(self, name):
-    super(MissingDisplayFrameRateError, self).__init__(
-      'Missing display frame rate metrics: ' + name)
 
 class SmoothnessController(object):
   def __init__(self):
     self._timeline_model = None
     self._tracing_timeline_data = None
     self._interaction = None
+    self._surface_flinger_timeline_data = None
 
   def SetUp(self, page, tab):
     # FIXME: Remove webkit.console when blink.console lands in chromium and
     # the ref builds are updated. crbug.com/386847
     custom_categories = ['webkit.console', 'blink.console', 'benchmark']
     custom_categories += page.GetSyntheticDelayCategories()
     category_filter = tracing_category_filter.TracingCategoryFilter()
     for c in custom_categories:
       category_filter.AddIncludedCategory(c)
     options = tracing_options.TracingOptions()
     options.enable_chrome_trace = True
     tab.browser.platform.tracing_controller.Start(options, category_filter, 60)
-    if tab.browser.platform.IsRawDisplayFrameRateSupported():
-      tab.browser.platform.StartRawDisplayFrameRateMeasurement()
+    if tab.browser.platform.IsDisplayTracingSupported():
+      tab.browser.platform.StartDisplayTracing();
 
   def Start(self, tab):
     # Start the smooth marker for all smooth actions.
     runner = action_runner.ActionRunner(tab)
     self._interaction = runner.BeginInteraction(
         RUN_SMOOTH_ACTIONS, is_smooth=True)
 
   def Stop(self, tab):
     # End the smooth marker for  all smooth actions.
     self._interaction.End()
     # Stop tracing for smoothness metric.
-    if tab.browser.platform.IsRawDisplayFrameRateSupported():
-      tab.browser.platform.StopRawDisplayFrameRateMeasurement()
+    if tab.browser.platform.IsDisplayTracingSupported():
+      self._surface_flinger_timeline_data = \
+          tab.browser.platform.StopDisplayTracing()
     self._tracing_timeline_data = tab.browser.platform.tracing_controller.Stop()
+    timeline_data = [self._tracing_timeline_data]
+    if self._surface_flinger_timeline_data:
+      timeline_data.append(self._surface_flinger_timeline_data)
     self._timeline_model = TimelineModel(
-      timeline_data=self._tracing_timeline_data)
+        timeline_data=timeline_data)
 
   def AddResults(self, tab, results):
     # Add results of smoothness metric. This computes the smoothness metric for
     # the time ranges of gestures, if there is at least one, else the the time
     # ranges from the first action to the last action.
     results.AddValue(trace.TraceValue(
         results.current_page, self._tracing_timeline_data))
     renderer_thread = self._timeline_model.GetRendererThreadFromTabId(
         tab.id)
     run_smooth_actions_record = None
@@ skipping 24 matching lines @@
         raise Exception('SmoothnessController failed to issue markers for the '
                         'whole interaction.')
       else:
         smooth_records = [run_smooth_actions_record]
 
     # Create an interaction_record for this legacy measurement. Since we don't
     # wrap the results that are sent to smoothness metric, the label will
     # not be used.
     smoothness_metric = smoothness.SmoothnessMetric()
     smoothness_metric.AddResults(
-      self._timeline_model, renderer_thread, smooth_records, results)
-    if tab.browser.platform.IsRawDisplayFrameRateSupported():
-      for r in tab.browser.platform.GetRawDisplayFrameRateMeasurements():
-        if r.value is None:
-          raise MissingDisplayFrameRateError(r.name)
-        if isinstance(r.value, list):
-          results.AddValue(list_of_scalar_values.ListOfScalarValues(
-              results.current_page, r.name, r.unit, r.value,
-              description=DESCRIPTIONS.get(r.name)))
-        else:
-          results.AddValue(scalar.ScalarValue(
-              results.current_page, r.name, r.unit, r.value,
-              description=DESCRIPTIONS.get(r.name)))
+        self._timeline_model, renderer_thread, smooth_records, results)
 
   def CleanUp(self, tab):
-    if tab.browser.platform.IsRawDisplayFrameRateSupported():
-      tab.browser.platform.StopRawDisplayFrameRateMeasurement()
+    if tab.browser.platform.IsDisplayTracingSupported():
+      tab.browser.platform.StopDisplayTracing()
     if tab.browser.platform.tracing_controller.is_tracing_running:
       tab.browser.platform.tracing_controller.Stop()