Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: LayoutTests/fast/table/display-table-caption-crash.html

Issue 804383002: Layout captions in simplifiedNormalFlowLayout for tables. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review feedback Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/table/display-table-caption-crash.html
diff --git a/LayoutTests/fast/table/display-table-caption-crash.html b/LayoutTests/fast/table/display-table-caption-crash.html
new file mode 100644
index 0000000000000000000000000000000000000000..f82530f2c2985dc7682fa071db1bf59c62e36556
--- /dev/null
+++ b/LayoutTests/fast/table/display-table-caption-crash.html
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<script src="../../resources/run-after-display.js"></script>
+<style>
+.c5:after {
+ position:absolute;
+ content: counter(c, lower-armenian) attr(id);
+ counter-increment: c 895;
+}
+.c5 { -webkit-transform:skew(20deg); }
+.c5:last-of-type { display: table-caption; }
+.c4:nth-of-type(2n+1) { counter-increment: c 578; }
Julien - ping for review 2014/12/16 16:05:53 Nit: It's preferred to give meaningful name for cl
dsinclair 2014/12/16 17:23:19 Done.
+</style>
+
+This test passes if it does not CRASH.
+
+<option>
+
Julien - ping for review 2014/12/16 16:05:53 You have a gazillion unneeded empty lines in your
dsinclair 2014/12/16 17:23:19 Done.
+
+<script>
+if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+}
+
+onload = function() {
+ var el = document.createElement('li');
+ el.setAttribute('class', 'c5');
+ document.body.appendChild(el);
+
+ runAfterDisplay(function() {
Julien - ping for review 2014/12/16 16:05:53 That's not needed AFAICT. Forcing a synchronous la
dsinclair 2014/12/16 17:23:19 Done.
+ var o = document.querySelector('option');
+ o.setAttribute('class', 'c4');
+
+ if (window.testRunner)
+ testRunner.notifyDone();
+ });
+}
+</script>
« no previous file with comments | « no previous file | LayoutTests/fast/table/display-table-caption-crash-expected.txt » ('j') | Source/core/rendering/RenderTable.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698