LayoutTests/fast/table/display-table-caption-crash.html - Issue 804383002: Layout captions in simplifiedNormalFlowLayout for tables.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/display-table-caption-crash.html

Issue 804383002: Layout captions in simplifiedNormalFlowLayout for tables. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Review feedback Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/run-after-display.js"></script>

	3 <style>

	4 .c5:after {

	5 position:absolute;

	6 content: counter(c, lower-armenian) attr(id);

	7 counter-increment: c 895;

	8 }

	9 .c5 { -webkit-transform:skew(20deg); }

	10 .c5:last-of-type { display: table-caption; }

	11 .c4:nth-of-type(2n+1) { counter-increment: c 578; }
	Julien - ping for review 2014/12/16 16:05:53 Nit: It's preferred to give meaningful name for cl Nit: It's preferred to give meaningful name for classes (especially when they come from ClusterFuzz). dsinclair 2014/12/16 17:23:19 Done. Show quoted text On 2014/12/16 16:05:53, Julien Chaffraix - PST wrote: > Nit: It's preferred to give meaningful name for classes (especially when they > come from ClusterFuzz). Done.
	12 </style>

	13

	14 This test passes if it does not CRASH.

	15

	16 <option>

	17
	Julien - ping for review 2014/12/16 16:05:53 You have a gazillion unneeded empty lines in your You have a gazillion unneeded empty lines in your test. While some spaces is welcome, this is past the required amount. dsinclair 2014/12/16 17:23:19 Done. Show quoted text On 2014/12/16 16:05:53, Julien Chaffraix - PST wrote: > You have a gazillion unneeded empty lines in your test. While some spaces is > welcome, this is past the required amount. Done.
	18

	19 <script>

	20 if (window.testRunner) {

	21 testRunner.dumpAsText();

	22 testRunner.waitUntilDone();

	23 }

	24

	25 onload = function() {

	26 var el = document.createElement('li');

	27 el.setAttribute('class', 'c5');

	28 document.body.appendChild(el);

	29

	30 runAfterDisplay(function() {
	Julien - ping for review 2014/12/16 16:05:53 That's not needed AFAICT. Forcing a synchronous la That's not needed AFAICT. Forcing a synchronous layout should work. It would also remove the need for waitUntilDone / notifyDone. dsinclair 2014/12/16 17:23:19 Done. Show quoted text On 2014/12/16 16:05:53, Julien Chaffraix - PST wrote: > That's not needed AFAICT. Forcing a synchronous layout should work. It would > also remove the need for waitUntilDone / notifyDone. Done.
	31 var o = document.querySelector('option');

	32 o.setAttribute('class', 'c4');

	33

	34 if (window.testRunner)

	35 testRunner.notifyDone();

	36 });

	37 }

	38 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/table/display-table-caption-crash-expected.txt » ('j') | Source/core/rendering/RenderTable.cpp » ('J')